Pickup upgrade not working with Ars Nouveau pickup spell

theboo commented 2 days ago

Putting this here because I think this is where the pickup upgrade is... This is an issue that existed early in 1.16 but you helped ars use the correct forge pickup events properly to make it work with the backpack pickup upgrade... In 1.21.1 neo, they no longer work together. Ars pickup glyph puts the items in my inventory but they never end up in the backpack.

As someone who knows mostly nothing, it looks like ars is using the correct neo events here: https://github.com/baileyholl/Ars-Nouveau/blob/5133633386148144c2d19e2190c11208f826775d/src/main/java/com/hollingsworth/arsnouveau/common/spell/effect/EffectPickup.java#L40

This has been reported to ars as well(in their 1.21 testing channel on discord), unsure which side is at fault here haha...

P3pp3rF1y commented 1 day ago

I am actually unable to recreate this one - when I try to use the pickup spell the backpack properly picks up the item. Maybe your pickup filter is preventing the item from being pulled in?

theboo commented 1 day ago

here's a gif of what i am experiencing in enigmatica 10 v 1.12.0, maybe we have some other mod conflicting? That's gonna be a nightmare to track down if so lol. i tried both block and allow mode on the advanced pickup filter.

https://gyazo.com/a8649a1db81ab0697e521126ea78fc3d

theboo commented 1 day ago

just to be sure i tried with the basic pickup upgrade as well, same result

theboo commented 1 day ago

made a quick instance with just ars, jei, sophisticated mods and dependencies, same result for me: https://gyazo.com/dfb650512bef7a8a3c64ab8e196a5152

neo 1.21.1 v21.1.72, all other mods whatever is latest on curseforge

P3pp3rF1y / SophisticatedCore

Pickup upgrade not working with Ars Nouveau pickup spell #294