P3pp3rF1y / SophisticatedStorage

GNU General Public License v3.0
23 stars 29 forks source link

Incompatibility with JEI #248

Closed SrRapero720 closed 1 year ago

SrRapero720 commented 1 year ago

ISSUE (sophisticated storage)

image

EXPECTED (sophisticated backpacks)

image

P3pp3rF1y commented 1 year ago

What versions of the mods are you using? any error related to sophisticated storage in the log?

This works correctly for most of the people including me and I find it odd that this wouldn't work for storage only because most of the logic is actually common to both of the mods and is done as part of sophisticatedcore. The only thing that storage does on top of that is just registering that logic to jei for its gui. So I am suspecting that some mod is messing with storage and breaking this compat.

SrRapero720 commented 1 year ago

My bad i forgot to mention version I am using 1.18.2 with MinecraftForge 40.2.9

SCore: sophisticatedcore-1.18.2-0.5.77.360.jar SStorage: sophisticatedstorage-1.18.2-0.8.37.554.jar SBackpacks: sophisticatedbackpacks-1.18.2-3.18.57.888.jar

Modpack: https://legacy.curseforge.com/minecraft/modpacks/marillanos/files

I found JEI is not working at all with SStorage For example

Items CAN'T be moved using JEI button (when crafting upgrade is present)

STORAGE 2023-07-16_22h16_47 2023-07-16_22h16_55

BACKPACKS 2023-07-16_22h17_05

MISSING BARRELS REPICE

Using JEI can't get repice for crafting chest or barrels using crafting table EXCEPT with Create Mod image image

SrRapero720 commented 1 year ago

note: repices are working (in crafting table) but JEI can't identify it

P3pp3rF1y commented 1 year ago

that basically means that the whole JEI integration didn't load. Anything in the log when JEI registers plugins? there should be something like Registering advanced plugins: sophisticatedstorage in the log or similar message for sophisticatedbackpacks or another mod and if there's issue with loading sophisticatedstorage plugin there should be error logged there.

SrRapero720 commented 1 year ago

you're right


[17:26:37] [Render thread/INFO] [me.je.co.lo.PluginCaller/]: Registering recipes: sophisticatedstorage:default ...
17:26:37.554
game
[17:26:37] [Render thread/ERROR] [me.je.co.lo.PluginCaller/]: Caught an error from mod plugin: class net.p3pp3rf1y.sophisticatedstorage.compat.jei.StoragePlugin sophisticatedstorage:default
17:26:37.554
game
at net.p3pp3rf1y.sophisticatedstorage.compat.jei.TierUpgradeRecipesMaker.lambda$getCraftingRecipes$0(TierUpgradeRecipesMaker.java:44) ~[sophisticatedstorage-1.18.2-0.8.37.554.jar%23205!/:1.18.2-0.8.37.554] {re:classloading}
17:26:37.554
game
at net.p3pp3rf1y.sophisticatedstorage.compat.jei.TierUpgradeRecipesMaker.lambda$getCraftingRecipes$1(TierUpgradeRecipesMaker.java:31) ~[sophisticatedstorage-1.18.2-0.8.37.554.jar%23205!/:1.18.2-0.8.37.554] {re:classloading}
17:26:37.554
game
at net.p3pp3rf1y.sophisticatedcore.compat.jei.ClientRecipeHelper.lambda$getAndTransformAvailableItemGroupRecipes$2(ClientRecipeHelper.java:42) ~[sophisticatedcore-1.18.2-0.5.77.360.jar%23204!/:1.18.2-0.5.77.360] {re:classloading}
17:26:37.554
game
at net.p3pp3rf1y.sophisticatedcore.compat.jei.ClientRecipeHelper.lambda$getAndTransformAvailableItemGroupRecipes$3(ClientRecipeHelper.java:40) ~[sophisticatedcore-1.18.2-0.5.77.360.jar%23204!/:1.18.2-0.5.77.360] {re:classloading}
17:26:37.554
game
at net.p3pp3rf1y.sophisticatedcore.compat.jei.ClientRecipeHelper.getAndTransformAvailableItemGroupRecipes(ClientRecipeHelper.java:40) ~[sophisticatedcore-1.18.2-0.5.77.360.jar%23204!/:1.18.2-0.5.77.360] {re:classloading}
17:26:37.554
game
at net.p3pp3rf1y.sophisticatedstorage.compat.jei.TierUpgradeRecipesMaker.getCraftingRecipes(TierUpgradeRecipesMaker.java:29) ~[sophisticatedstorage-1.18.2-0.8.37.554.jar%23205!/:1.18.2-0.8.37.554] {re:classloading}
17:26:37.554
game
at net.p3pp3rf1y.sophisticatedstorage.compat.jei.StoragePlugin.registerRecipes(StoragePlugin.java:149) ~[sophisticatedstorage-1.18.2-0.8.37.554.jar%23205!/:1.18.2-0.8.37.554] {re:classloading}
P3pp3rF1y commented 1 year ago

ok so from that I can see there was an error loading that, but I don't see what error so I can't help without more info. Could you share the full log on something like pastebin.com?

SrRapero720 commented 1 year ago

sorry for the late response here is both (latest and debug.log) https://gist.github.com/SrRapero720/fb9a3dfbde175e9601195ab5df685516

P3pp3rF1y commented 1 year ago

Looks like for some reason at least one of the tier upgrade recipes is invalid and that causes the logic that adds these in JEI to fail. Are you or the pack maker changing these in any way?

SrRapero720 commented 1 year ago

ehhh nope, i am the creator of the modpack and i didn't make changes to config of the mod. (even the mod itself)

SrRapero720 commented 1 year ago

i figure out what is happen MCA is the mod causing the bug removing it fixes the issue

SrRapero720 commented 1 year ago

WITH MCA

image

WITHOUT MCA

image 2023-07-26_17h16_55

MuteTiefling commented 1 year ago

We're seeing the same thing in Enigmatica 9. https://github.com/EnigmaticaModpacks/Enigmatica9/issues/546

The normal mode does not change any recipes and we're seeing it there as well.

The + appears in backpacks with the crafting upgrade, but not in barrels with the upgrade.

We don't have MCA, so that's out, but I wouldn't fully discount a mod conflict somewhere.

MC: 1.19.2 JEI: jei-1.19.2-forge-11.6.0.1016 Sophisticated Core: sophisticatedcore-1.19.2-0.5.82.382 Storage: sophisticatedstorage-1.19.2-0.8.38.555 Backpacks: sophisticatedbackpacks-1.19.2-3.18.55.889 Logs: https://gist.github.com/MuteTiefling/fc87361a238167d7542739d41d46deeb

SrRapero720 commented 1 year ago

New update fixes the issue, now with MCA works fine. move to crafting table works and gui interface moves when upgrade menu is opened

2023-08-09_01h16_40 2023-08-09_01h17_17 2023-08-09_01h17_41