[Create][BuildingGadgets2] Wrong chest are being placed in world when using building tools

[agreedSkiing]

I originally posted this bug on the https://github.com/Direwolf20-MC/BuildingGadgets2 git but noticed after a test that this also happens with Create (version: 0.5.1.f) Schematicannon so I'm recreating it here.

Bug with Create Schematiccannon

Mods in this Minecraft instance [✔] buildinggadgets2-1.0.7 [✔] cofh_core-1.20.1-11.0.0.51 [✔] create-1.20.1-0.5.1.f [✔] sophisticatedbackpacks-1.20.1-3.20.3.1034 [✔] sophisticatedcore-1.20.1-0.6.12.589 [✔] sophisticatedstorage-1.20.1-0.10.12.768 [✔] thermal_cultivation-1.20.1-11.0.0.22 [✔] thermal_dynamics-1.20.1-11.0.0.21 [✔] thermal_expansion-1.20.1-11.0.0.27 [✔] thermal_foundation-1.20.1-11.0.1.63 [✔] thermal_innovation-1.20.1-11.0.0.21 [✔] thermal_integration-1.20.1-11.0.0.23 [✔] thermal_locomotion-1.20.1-11.0.0.17

To reproduce

1. Create a minecraft world with creative
2. Get the schematicannon, schematic and quill, schematic table, a normal chest, a sophisticated storage birch chest, gunpowder.
3. Place the birch chest in the world
4. Create a schematic by coping the place birch chest by right clicking it twice with the schematic and quill.
5. Place the schematic and quill in the schematic table to create a finished schematic that will place on birch chest according to the preview
6. Right click somewhere close to the schematic canon to lock the position to where the schematic shall output the chest
7. Place the schematic into the schematicannon and it preview the correct chest will be placed into the world.
8. Load the schematic cannon with gunpowder and place the normal chest right next to the cannon with a birch chest inside the normal minecraft chest.
9. Tell the schematicannon to start creating the block in the world.
10. Now an Acacia chest has been placed and the birch chest from that was placed in the normal minecraft chest next to the schematicannon is gone.

Bug reported from the BuildingGadgets2 git

Original text from https://github.com/Direwolf20-MC/BuildingGadgets2/issues/89

Building Gadgets Version 1.0.7

Describe the bug When using the copy paste, cut and paste or build tool with sophisticated storage the wrong chests are being placed into the world.

To Reproduce Using the building gadget with Minecraft 1.20.1

1. Install this mod, sophisticated storage core (0.6.12.589) and sophisticated storage (0.10.12.768)
2. Launch Minecraft and create a creative world with cheats
3. Get the build gadget.
4. Create a stack of sophisticated storage chests in your inventory or a bound inventory that isn't a sophisticated storage Acacia chest
5. Place (regardless of creative mode or not) and selected the sophisticated storage chest from step 5 and select it for the build tool.
6. Now the build tool will show an sophisticated storage Acacia chest when preview what will be placed/created and convert the chests from step 4 in your inventory to sophisticated storage Acacia chest when placed.

Expected behavior The selected sophisticated storage chest type is shown in the preview placement and placed in the world and not converted from one chest to another type.

Screenshots

Log Files Crash logs are extremely important in helping me figure out how I DireDerped.

NOTE ON RUBIDIUM Rubidium contains code that will crash many mods when used in conjunction with them. Unfortunately this includes Building Gadgets 2. There is absolutely nothing I can do on my side to prevent these crashes. If you're using Rubidium and your game crashes when rendering something, please try without rubidium before submitting a bug report.

[P3pp3rF1y]

I can take a look, but this is very very likely on the other mods' side because it seems they are not having the block entity load the correct nbt or they are not having it sync/rerender the block after it was loaded (this one you can actually check by reloading the world and seeing if the block shows correctly)

[agreedSkiing]

After reloading the world, by using Save and Quit to title, and looking at the preview from the schematicannon it still displays the brich chest, but when schematicannon placed the chest it was converted to an Acacia chest 🫤

[P3pp3rF1y]

So even after reload the chest that was placed before reload stays as Acacia instead of birch?

[agreedSkiing]

Yes

[agreedSkiing]

Adding another mod to the list of this behaviour constructionwand-1.20.1-2.11. This behaviour does not really require me to have chest in my inventory when doing it in create but I had it. And the glowing birch chest is from another attempt with create schematicannon to see if it would place the correct block in the world if I was in survival mode.

https://github.com/P3pp3rF1y/SophisticatedStorage/assets/93997033/2b4bbf72-aa0f-4c6d-b7ae-0a7b75ae9b29

[P3pp3rF1y]

With construction wand mod it's super easy it just doesn't set any block entity data so of course the chest will be acacia because it is never set to be birch by that mod.