fix: cron.matchDate always returning true for day of month, when either weekday or day of month is unrestricted

P4sca1 / cron-schedule

A zero-dependency cron parser and scheduler for Node.js, Deno and the browser.

MIT License

177 stars 15 forks source link

fix: cron.matchDate always returning true for day of month, when either weekday or day of month is unrestricted #271

Closed ghost closed 2 years ago

P4sca1 commented 2 years ago

@renzo-s Thank you for the pull request! Could you please target your PR against the dev branch? Every commit to master automatically drafts a new release and I would like to release your bug fix together with other changes. I already added tests to the dev branch for the issue that you reported, which currently fail. Hopefully these turn green when your PR arrives.

Edit: Nevermind, I found a way to do this without the need to rebase.

P4sca1 commented 2 years ago

:tada: This PR is included in version 3.0.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

ghost commented 2 years ago

🎉 Thanks for integrating so quickly! Sorry wasn't aware of your CI-pipeline. Rebasing is something I also try and avoid if possible. Possibly because I don't understand it fully ;)