search

P5-wrapper / react

A wrapper component that allows you to utilise P5 sketches within React apps.
https://P5-wrapper.github.io/react/
MIT License
500 stars 50 forks source link

Update README.md, fix the install command guide. #437

Closed nooooocato closed 3 months ago

nooooocato commented 3 months ago

Fixes #

Proposed Changes

If you do not install @types/p5 while installing this package, TypeScript development tools will not provide complete type hints.

Additional Notes (optional)

It might be better to provide a complete explanation and mention the --save-dev option, I'm not sure.

jamesrweb commented 3 months ago

Please run the format script and push the formatting fixes.

Please also have the two install steps, one for the dependencies and one for the development dependencies and add an explanation for each as you also recommend yourself ☺️.

Thank you in advance. 👍🏻

jamesrweb commented 3 months ago

Closed in favour of #457

nooooocato commented 2 weeks ago

Please run the format script and push the formatting fixes.

Please also have the two install steps, one for the dependencies and one for the development dependencies and add an explanation for each as you also recommend yourself ☺️.

Thank you in advance. 👍🏻

Thank you. I'm sorry I saw it so late. I have no experience in open source and don't often read notifications. Anyway, #457 is good to solve it.

jamesrweb commented 1 week ago

No need to apologise @nooooocato, thank you so much for the contribution and I hope you do so again in future! ❤️