`bark_generate_audio` accepts an output path but does not actually write to it

PABannier / bark.cpp

Suno AI's Bark model in C/C++ for fast text-to-speech

MIT License

630 stars 48 forks source link

`bark_generate_audio` accepts an output path but does not actually write to it #156

Closed sindresorhus closed 2 months ago

sindresorhus commented 2 months ago

https://github.com/PABannier/bark.cpp/blob/d8bd0fd05d4d688547e31979d77e88381ed3e1f2/bark.cpp#L2065C6-L2066

The parameter should either be removed or it should write to the given output path. I would prefer the latter, as most use-cases for this is to simply write to a WAV file, and it would be nice if this library took care of it.

PABannier commented 2 months ago

Hi @sindresorhus ! Thanks for catching this! This has been removed in #155 . Closing as this is solved.