Added GMA mounter via Lua so that workshop tools can be added by everyone!

PAC3-Server / notagain

Custom Servercontent for the official PAC3 Server.

GNU General Public License v3.0

13 stars 22 forks source link

Added GMA mounter via Lua so that workshop tools can be added by everyone! #92

Closed NanoAi closed 7 years ago

NanoAi commented 7 years ago

PLEASE REVIEW/EDIT THE FILE PATHS IN HERE BEFORE ACCEPTING THIS PULL

This should let people mount GMA files through the workshop at-least for now... the function may be removed from the server side in the future so we may need to think about either making a module or switching to a different method later. From what I've tested everything seems to work fine with no real issues besides Maps.

I've also included some workshop addons in this pull as a proof of concept. Obviously I take no credit for these and all credit goes to the original authors.

WARNING: Maps do work through this however they seem to get Checksum errors!
Checksum errors may happen with models.
No known errors with materials.
No known errors with tools.

CapsAdmin commented 7 years ago

Why can't we use https://github.com/PAC3-Server/notagain/blob/master/lua/notagain/pac_server/autorun/server/workshop_resources.lua ?

NanoAi commented 7 years ago

@CapsAdmin As far as I know http://wiki.garrysmod.com/page/resource/AddWorkshop will not add new files to the server and will only make clients download them. This may cause issues when trying to upload things like tools, or models, etc.

Myaats commented 7 years ago

Looking at the LoadGMA function is deprecated and why we even need to download workshop serverside (Looking at how nearly all of them have backdoors). I would say this would probably not work for us. @CapsAdmin @Earu @Techbot121 ?

NanoAi commented 7 years ago

@Datamats Yeah that's why I said that the function may be removed from the server side in the future, but it's still around for now. I made it because we wanted to have some workshop tools on the server as a temp thing so that people can start joining and building and what not. I've actually reviewed most of those gma files (the ones included), and they didn't seem to contain anything malicious.

Earu commented 7 years ago

Ill be honest here I think its not a good idea, I like the fact its the admins that decide what should be added or not, committers shouldnt have that right. If they want something so bad then they can code it.

NanoAi commented 7 years ago

Seems like more people are against it then for it. Just going to close it.