Closed NanoAi closed 7 years ago
Not the right place, you should push that into inserts/preload @LuaTenshi
Try not to add stuff to player metatable. I'm not saying don't at all but in the long run it's confusing for people who read the code.
You're only using this in one place, can it not just be a local function?
Actually it was already in the goto code you have, and was checked as a player function. So I just added it to the meta for consistency.
On Mon, Jun 5, 2017, 10:23 AM Elias Hogstvedt, notifications@github.com wrote:
Try not to add stuff to player metatable. I'm not saying don't at all but in the long run it's confusing for people who read the code.
You're only using this in one place, can it not just be a local function?
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/PAC3-Server/notagain/pull/97#issuecomment-306200443, or mute the thread https://github.com/notifications/unsubscribe-auth/AC9ACPkt5FaRI6PUViT_ngJ5OHq1irHfks5sBA9QgaJpZM4NvsfR .
Still its in the wrong place, at least do it in a preload folder
Then move it to the right place?
On Mon, Jun 5, 2017, 10:45 AM R.Réno, notifications@github.com wrote:
Still its in the wrong place
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PAC3-Server/notagain/pull/97#issuecomment-306206127, or mute the thread https://github.com/notifications/unsubscribe-auth/AC9ACEdv6aUH5FJjNGfy0R3bSu25-omZks5sBBR4gaJpZM4NvsfR .
I can't move it currently as I'm not at home and have no idea how to do it on mobile. You can try to move it now as when I made the pull I allowed edits but if you don't want to or just can't be asked I'll move it into the correct location when I get home.
On Mon, Jun 5, 2017, 10:54 AM Ani Foxx, luatenshi@gmail.com wrote:
Then move it to the right place?
On Mon, Jun 5, 2017, 10:45 AM R.Réno, notifications@github.com wrote:
Still its in the wrong place
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PAC3-Server/notagain/pull/97#issuecomment-306206127, or mute the thread https://github.com/notifications/unsubscribe-auth/AC9ACEdv6aUH5FJjNGfy0R3bSu25-omZks5sBBR4gaJpZM4NvsfR .
It's leftover code from metastruct. I think Python1320 wrote it. My point still stands though.
If you find silly things like this feel free to correct them. Of course consistency is nice but we or I can write bad code as well.
If you had direct commit access I probably wouldn't care (or I'd fix it in a refactor commit or something) but because of how pull requests work you tend to be more critical.
Added
PLAYER:LookAt
also added a misc.lua for various short functions that don't really need their own file.