search

PAGalaxyLab / YAHFA

Yet Another Hook Framework for ART
GNU General Public License v3.0
1.56k stars 350 forks source link

`shouldVisiblyInit` on x86 platform #156

Closed ghost closed 2 years ago

ghost commented 2 years ago

Previously, shouldVisiblyInit returns 0 on x86 platform, but after commit 60bedad it returns 1. Is this intended or not?

static int shouldVisiblyInit() {
#if defined(__i386__) || defined(__x86_64__)
    return 0;
#else
    if(SDKVersion < __ANDROID_API_R__) {
        return 0;
    }
    else return 1;
#endif
}
static int shouldVisiblyInit() {
#if defined(__i386__) || defined(__x86_64__)
    return 1;
#else
    if(SDKVersion < __ANDROID_API_R__) {
        return 0;
    }
    else return 1;
#endif
}
rk700 commented 2 years ago

Oh yes that's a bug. Thank you for filing it. Would you make a pull request?

ghost commented 2 years ago

Thanks, but I am not inclined to make a pull request.