PAGalaxyLab / vxhunter

ToolSet for VxWorks Based Embedded Device Analyses
BSD 2-Clause "Simplified" License
334 stars 70 forks source link

Bug Fix for VxAnalyzer, Fail Faster in Netpool Analysis #12

Closed svidovich closed 4 years ago

svidovich commented 4 years ago

Hello! Here is a PR that doesn't include any changes to logging whatsoever. I've packed it into one commit to make your life easier. I hope you enjoy!

This PR fixes an exception in analyze_active_task in VxAnalyzer. When active_qhead is None, the function causes an exception. I avoid this by nesting all of that code in an if active_qhead block.

Also, I noticed that Netpool analysis could fail faster: since it is unsupported in VxWorks 6.x, we should ask for the VxWorks version immediately, and return immediately supposing that 6.x is chosen.

dark-lbp commented 4 years ago

Merged, thanks for the pr.