PAHFIT / pahfit

Model Decomposition for Near- to Mid-Infrared Spectroscopy of Astronomical Sources
https://pahfit.readthedocs.io/
18 stars 26 forks source link

Estimate init #101

Closed alexmaragko closed 3 years ago

alexmaragko commented 3 years ago
karllark commented 3 years ago

Please push any changes to this branch. A PR was just merged that should mean the tests will now pass. And shouldn't conflict at all with this PR.

codecov-io commented 3 years ago

Codecov Report

Merging #101 (5768a90) into master (8fd1b28) will decrease coverage by 12.57%. The diff coverage is 23.07%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #101       +/-   ##
===========================================
- Coverage   72.24%   59.67%   -12.58%     
===========================================
  Files           4        4               
  Lines         245      243        -2     
===========================================
- Hits          177      145       -32     
- Misses         68       98       +30     
Impacted Files Coverage Δ
pahfit/component_models.py 43.24% <0.00%> (-2.71%) :arrow_down:
pahfit/base.py 50.33% <27.27%> (-19.61%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 23c4ba2...5768a90. Read the comment docs.

alexmaragko commented 3 years ago

Thank you for the constructive comments, I sorted out a couple of things on arguments.