PAHFIT / pahfit

Model Decomposition for Near- to Mid-Infrared Spectroscopy of Astronomical Sources
https://pahfit.readthedocs.io/
18 stars 26 forks source link

Estimate feature strengths #151

Closed alexmaragko closed 2 years ago

alexmaragko commented 3 years ago

This PR should replace #141.

Differences with #141:

codecov-commenter commented 2 years ago

Codecov Report

Merging #151 (52db8bd) into master (e576207) will decrease coverage by 0.82%. The diff coverage is 43.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
- Coverage   62.65%   61.83%   -0.83%     
==========================================
  Files           7        8       +1     
  Lines         399      414      +15     
==========================================
+ Hits          250      256       +6     
- Misses        149      158       +9     
Impacted Files Coverage Δ
pahfit/base.py 57.07% <42.85%> (-0.75%) :arrow_down:
pahfit/feature_strengths.py 44.44% <44.44%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e576207...52db8bd. Read the comment docs.

alexmaragko commented 2 years ago

Feature strengths are now calculated by default. No argument required. Not sure why "link_test" canceled in the checks.

karllark commented 2 years ago

Re-running the checks. Sometimes they fail just because. ;-)

karllark commented 2 years ago

@alexmaragko: is this PR ready for merging in your view? Have you responded to all the comments?

alexmaragko commented 2 years ago

@alexmaragko: is this PR ready for merging in your view? Have you responded to all the comments?

@karllark Yes I believe so.

karllark commented 2 years ago

Thanks for the response. There are multiple approvals so will merge.