els1 commented 2 years ago

Added "intrinsic" or "unattenuated" to amplitudes of BB and features (issue 130)

Added comment that we use astropy Gaussian1D and Drude1D + link (issue 122)

Added comment stating IDL PAHFIT uses fractional FWHM while here we use FWHM for Drude profiles (issue 152). We can update this if we decide to change it.

codecov-commenter commented 2 years ago

Codecov Report

Merging #159 (9f271cf) into master (c0b4f2b) will decrease coverage by 0.82%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
- Coverage   62.65%   61.83%   -0.83%     
==========================================
  Files           7        8       +1     
  Lines         399      414      +15     
==========================================
+ Hits          250      256       +6     
- Misses        149      158       +9

Impacted Files	Coverage Δ
pahfit/base.py	`57.07% <0.00%> (-0.75%)`	:arrow_down:
pahfit/feature_strengths.py	`44.44% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c0b4f2b...9f271cf. Read the comment docs.

els1 commented 2 years ago

I also changed the file pahfit.component_models.BlackBody1D.rst and pahfit.component_models.S07_attenuation.rst (so I can reference them) but git does not say they are changed nor upload them. Not sure why.

karllark commented 2 years ago

@els: ready for review?

els1 commented 2 years ago

@karllark yes

PAHFIT / pahfit

small changes to docs #159

Codecov Report