Closed alexmaragko closed 2 years ago
Merging #164 (ababe61) into master (0d24d90) will decrease coverage by
3.18%
. The diff coverage is15.00%
.
@@ Coverage Diff @@
## master #164 +/- ##
==========================================
- Coverage 54.92% 51.74% -3.19%
==========================================
Files 8 8
Lines 477 516 +39
==========================================
+ Hits 262 267 +5
- Misses 215 249 +34
Impacted Files | Coverage Δ | |
---|---|---|
pahfit/base.py | 55.12% <14.28%> (-1.67%) |
:arrow_down: |
pahfit/feature_strengths.py | 21.15% <15.15%> (-10.43%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0d24d90...ababe61. Read the comment docs.
Is this PR ready to merge? Or is more review needed?
Is this PR ready to merge? Or is more review needed?
From my end it is ready. I have addressed the raised comments.
@els1 : ok to merge?
@Ameek-Sidhu and @els : ok for merging?
It is ready to merge from my perspective.
Good to merge.
This PR adds the equivalent width calculation of the separate components, and those of the combined dust features, and should replace PR #143.
An updated output table is also provided in
fit_spectrum.rst
.Differences with PR #143:
eqws
method is now part of thefeature_strengths
module.