Closed jancami closed 2 years ago
Merging #214 (9eaa244) into master (71d422a) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #214 +/- ##
=======================================
Coverage 52.38% 52.38%
=======================================
Files 8 8
Lines 567 567
=======================================
Hits 297 297
Misses 270 270
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 71d422a...9eaa244. Read the comment docs.
BTW, sounds like you have a JWST insider. Ask them if they have an "approved" naming convention for their instrument names/segments/etc. The hope is that pipeline/reduction tools use these, and PAHFIT users don't have to do anything. I asked Patrick Ogle this a few months back and he didn't know of any such standard. If not, we can "set" the standard and advocate for its use in pipeline analysis tools.
I made all changes you suggested. We could still simplify since the wavelength ranges are the same for different speeds for SWS. Right now, I repeat them for each speed since I thought that may be easier to parse. But happy to change that to a single entry for each band if you would prefer that!
This looks great, thanks Jan. For the segments that have no letter (like 4
), yaml
codes those as an int on input, which is fine, but different than the strings like 1a
. Maybe worth just forcing a string by adding quotes: '4'
. Other than that, I haven't checked these against reality, but we can merge and correct later if necessary.
Hoping for some Spitzer/JWST lovely packs too (and we can work on the reader class for them).
I went ahead and did so. Merging.
ISO SWS instrument packs in yaml format. Wavelength ranges are given for each band, as well as polynomial coefficients that represent the resolving power.