search

PAHFIT / pahfit

Model Decomposition for Near- to Mid-Infrared Spectroscopy of Astronomical Sources
https://pahfit.readthedocs.io/
18 stars 26 forks source link

New regression tests for YAML pack loading and fitting #234

Open drvdputt opened 1 year ago

drvdputt commented 1 year ago

Related to #233 .

The test test_classic_pack had the original goals of comparing the read-in param_info, to one that was hardcoded in PAHFIT_Spitzer_Exgal (which I assume was some older implementation.

With the new YAML pack, and the new Model class from #233 , I don't think it makes sense to keep supporting this test, and the old way of doing science packs (hardcoding them).

We should probably remove all of this code. Or more conservatively, replace this test by one that has with a hardcoded Features table, just to check that the yaml parsing works correctly.

jdtsmith commented 1 year ago

I'd remove this for now. We can come up with new principled tests which point straight at the problem of model stability (that we don't accidentally screw up the model by "improving it" over time). For that, we need the model in a good place that we all agree is worth "check-pointing". We're not quite there.

drvdputt commented 1 year ago

I removed them in my latest commit to #233 . Changed the title to reflect what we need to do after the merge.