PAHFIT / pahfit

Model Decomposition for Near- to Mid-Infrared Spectroscopy of Astronomical Sources
https://pahfit.readthedocs.io/
18 stars 26 forks source link

updated ISO/SWS yaml file #238

Closed jancami closed 1 year ago

jancami commented 1 year ago

Updated the ISO yaml file following JD's findings that it returned incorrect results. I've also slightly modified the segment naming to be more consistent with the proper nomenclature that was used for ISO.

codecov-commenter commented 1 year ago

Codecov Report

Merging #238 (a33f1e2) into master (a624722) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #238   +/-   ##
=======================================
  Coverage   44.13%   44.13%           
=======================================
  Files          13       13           
  Lines         836      836           
=======================================
  Hits          369      369           
  Misses        467      467           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jdtsmith commented 1 year ago

Thanks. @drvdputt since you found this in your tests can you take a quick look to see if your fits are now doing well?

drvdputt commented 1 year ago

These new widths are producing excellent fits. Here's a zoom-in for the Orion D5 data.

Figure 1 Figure 1(1) Figure 1(2)

jdtsmith commented 1 year ago

Awesome, merged, thanks both.