search

PAIR-code / facets

Visualizations for machine learning datasets
https://pair-code.github.io/facets/
Apache License 2.0
7.36k stars 887 forks source link

Dive_demo Display in Jupyter Notebook #124

Open contractorwolf opened 6 years ago

contractorwolf commented 6 years ago

It was suggested by @jameswex that UI changes should be submitted as a mockup instead of attempting to actually attempt to do them myself. I am attaching my design change to this issue. My change is fairly simple and just would create a larger area to display the sprites and facets: divedemouichange

Let me know what you think. I just cut-up a screenshot of the current version, so it is not perfect but it shows the general idea. The active display area would be between the far left side and the color legend on the right. The zoom in/ zoom out and resize buttons would probably be best on the far left size (not as pictured).

jameswex commented 6 years ago

Thanks for this! Our visual designer actually just gave us some new mocks that move the controls to a top bar just like you have. Also it simplifies the legend, due to our new top-bar containing legend-like info. The info card is still on the right-side as many datasets contain a huge number of features and the vertical scrolling makes sense to us in that case, as opposed to a grid-like layout we would need to scroll with a bottom bar for info cards.

I'm submitting a change today that implements these changes. Let me know what you think, if you build the vis at head later today. I'm not updating the precompiled dist version just yet as we may have more slight visual tweaks.

contractorwolf commented 6 years ago

cool, glad you like it, looking forward to seeing what the new changes look like. The main reason I was thinking of this is just that it is somewhat difficult to visualize your data in a small box in Jupyter Notebooks, hopefully your changes will help. I still have this open PR for the dynamic sprite sizes as well: https://github.com/PAIR-code/facets/pull/123