search

PAIR-code / facets

Visualizations for machine learning datasets
https://pair-code.github.io/facets/
Apache License 2.0
7.35k stars 887 forks source link

HTML Imports is deprecated error still here! #228

Closed markddesimone closed 3 years ago

markddesimone commented 3 years ago

image

I was getting this error so I checked the sample: https://colab.research.google.com/github/PAIR-code/facets/blob/master/colab_facets.ipynb. it is still getting the error.

I am on linux Ubuntu 18.04.5 LTS, Chrome Version 85.0.4183.121 (Official Build) (64-bit)

The script is using:

as recommended as the solution in https://github.com/PAIR-code/facets/issues/206 and https://github.com/PAIR-code/facets/issues/211

jameswex commented 3 years ago

Thanks for reaching out. That warning in the console is now expected, as Facets uses HTML imports, but through the webcomponents polyfill script, which is necessary since native suppoort was removed in Chrome M80.

Assuming the Facets visualizations are working as expected, the warning should be ignored.

markddesimone commented 3 years ago

@jameswex, thank you. It works when the cell is first executed but if I re-run the cell I have the issues described in https://github.com/PAIR-code/facets/issues/227. I had been wondering if this was the cause. I have to totally restart jupyter to get my cell to render properly again, just shutting down the kernel for my notebook does not resolve it...

mugglmenzel commented 3 years ago

The issue still is present in Jupyter notebooks. Facets is not usable anymore on any Google Cloud notebook (CAIP, Vertex AI).

jameswex commented 3 years ago

@mugglmenzel As a test I just created a new virtualenv, did "pip install jupyter facets-overview protobuf", then ran "jupyter notebook" and ran the "Facets Dive and Overview Colab Example" notebook (skipping the first cell as that is only for when running in colab). I was able to see the Facets visualization, even though the HTML imports warning is shown (as expected).

Are you able to use it in plain Jupyter notebooks? I'm wondering if the issue is with a specific notebook environment and not all jupyter notebooks.

shawngiese commented 3 years ago

I just tried it too... new virtualenv, did "pip install jupyter facets-overview protobuf", and ran "jupyter notebook". Then my own data loaded fine. I still get the same "HTML Imports is deprecated" warning but the facets overview loads fine (1.7 million rows). In my non-virtualenv with lots of libraries, the facets-overview never loads.