search

PAIR-code / facets

Visualizations for machine learning datasets
https://pair-code.github.io/facets/
Apache License 2.0
7.36k stars 886 forks source link

replace deprecated numpy.asscalar #250

Closed jli closed 1 year ago

jli commented 1 year ago

numpy.asscalar has been deprecated since 1.16 [1], and was removed in numpy 1.23.0 [2].

This PR lets facets-overview be used with numpy versions >= 1.23. facets-overview breaking on numpy > 1.22 is causing test failures in my attempt to allow apache-beam to use numpy >1.22: https://github.com/apache/beam/pull/25003#issuecomment-1382403867

Thanks!

[1] asscalar deprecated https://numpy.org/doc/1.22/reference/generated/numpy.asscalar.html [2] removed in 1.23.0 https://numpy.org/doc/stable/release/1.23.0-notes.html#expired-deprecations

tvalentyn commented 1 year ago

Hi there! when can this fix be released? Thanks, @jli for the fix!