PALEOtoolkit / PALEOboxes.jl

Model coupler for the PALEO model framework
https://PALEOtoolkit.github.io/PALEOboxes.jl
MIT License
2 stars 1 forks source link

Fix for const ReactionReservoirScalar #87

Closed sjdaines closed 1 year ago

sjdaines commented 1 year ago

Problem was introduced in https://github.com/PALEOtoolkit/PALEOboxes.jl/pull/74

ReactionReservoirScalar shouldn't add R_sms variable to do_reactionreservoirscalar method, as that fails if const=true (where R_sms is than a VarTargetScalar) and another reaction that depends on R also tries to write R_sms (creates a dependency loop).