search

PANmedia / raptor-editor

Raptor, an HTML5 WYSIWYG content editor!
www.raptor-editor.com
GNU General Public License v3.0
533 stars 136 forks source link

Why can't I build 1.4.1? #162

Closed atomiku closed 10 years ago

atomiku commented 10 years ago

The build files were removed. If I put them back and I try to run ./bin/build-all.sh but I get errors. Argh!

atomiku commented 10 years ago

Okay I cloned the raptor-editor instead of raptor-builder. Then I had to install a bunch of gems. And then I was getting missing directories. Eventually found out I had to download all the raptor- repos such as locale, editor, dependencies etc. Please update the build instructions so others don't make the same mistake as me! I spent 5 hours getting this to work.

1.4.1 fixes the style toolbar bugs I was having with 1.2 though. Check: #154

atomiku commented 10 years ago

Also please note I had to: npm install clean-css@1.1.7

Running npm install clean-css would install 2.2.16 and that version is not compatible with the builder. (Check for yourself, it throws errors because a function name was changed or something)

Petah commented 10 years ago

Hi,

What build instructions were you looking at?

These seem to be up to date: https://github.com/PANmedia/raptor-editor/wiki/Building-and-Running-from-Source https://www.raptor-editor.com/documentation/tutorials/build-run-from-source

I just did a quick test an it seemed to work ok. The clean-css package should be locked to ~1.0.12 as per https://github.com/PANmedia/raptor-build/blob/master/package.json#L8

atomiku commented 10 years ago

I must have done something wrong then?? It didn't install the clean-css package for me, it just complained of it not existing which is why I had to install it myself. Building from Ubuntu.

atomiku commented 10 years ago

Actually it would be nice to offer prebuilt packages please, the version available on the website is outdated now and I had to go through a long process just to get this build (install ubuntu virtual machine, php5, ruby, etc etc etc)

Petah commented 10 years ago

The website shouldn't be outdated. I'll have a quick check.

But yea the build requirements are quite high unfortunately. I currently build on Windows, and the server builds on Debian. There hasn't been many major issues around installing dependencies when building.

I think nodejs is actually better than the old build process. It used to require closure and yui-compressor installed on you path. If you have suggestions I am open to them.

Petah commented 10 years ago

The server seems up to date, if you can elaborate on any issues I will take a look.

atomiku commented 10 years ago

I must say, thanks for the great work on this. It has allowed me to build a template-based article builder for users to post articles to my CMS. They can add a number of pre-defined blocks into the raptor area, such as 2-col, 2-col with image, full width image, etc etc. Works great!

The latest version on the website is 1.2.4? EDIT: The homepage says 1.2.4 released, let me check the builder

Petah commented 10 years ago

Oh, the content on the website is wrong. It is currently building the latest dev-master version.

atomiku commented 10 years ago

Okay the problem is that the builder doesn't tell you which version, and there are no comments in the raptor js or css files to tell you which version of the file you are using. It would be handy to include this, for instance if future developers of my project need to see if raptor needs to be updated etc etc.

So if its building the dev-master, well something happened to fix the issue with the style toolbar since building it myself. oh well. weird.

Petah commented 10 years ago

I've added an issue about letting users know what version they are using: https://github.com/PANmedia/raptor-editor/issues/166

I will look into it ASAP (probably won't be for about 3 weeks sorry).

Also I let me know if you want me to look into the issues with the downloaded version. If you have an example page it would be easiest.

atomiku commented 10 years ago

That's great. thanks. No rush - raptor is working for me and I don't see any need to update it for a while now. I have a rough idea of the version 1.4.2 something? That's good enough for me!

Cheers.

Petah commented 10 years ago

On a side note I would be interested to see this "2-col, 2-col with image, full width image" functionality you are talking about.

image

atomiku commented 10 years ago

It works great. How do I send you a private message?

Petah commented 10 years ago

You can send me an email via dave@raptor-editor.com

atomiku commented 10 years ago

I sent you an email. That editor looks nice!