search

PANmedia / raptor-editor

Raptor, an HTML5 WYSIWYG content editor!
www.raptor-editor.com
GNU General Public License v3.0
533 stars 136 forks source link

.ui-widget-overlay { z-index: 3000 !important; } ? #163

Closed zmilan closed 8 years ago

zmilan commented 10 years ago

Hi,

Is there any reason why this overlay z-index is set to be so big and even more !important? I add raptor-editor into my application and because of this settings I cant use any of modal dialog that exist in raptor-editor (for example setup link options). I fix it for my project with removing this z-index, but I'm wonder is there any reason why its there and also if possible what issues I can have with removing it.

Petah commented 10 years ago

The reason is we have guidelines for our particular apps about z-index:

image

However this obviously will not suit everybody's needs. I can look into this issue and try an make it more generic if possible. Let me know your requirements and I will have a look.

zmilan commented 10 years ago

@Petah thanks for your answer. I was never see this list before. Maybe I wasn't explain it good, this looks reasonable if raptor-editor is on top of complete page, but I run it in 'inline' mode, like part of other elements on page. I'm also not sure that its maybe not something in conflict with other part of my application, but it just put overlay on top of dialog and make it not usable. I will also try to see how its work on my simpler page and try to check is it maybe just connected with rest of my application.

Petah commented 10 years ago

Might be best if you could show me an example of the issue as it probably dependant on your usecase.

If you dont want to post it here feel free to email me at petah.p@gmail.com

deeknow commented 9 years ago

@zmilan just wondering how you got on with the z-index issue, did you end up modifying your own z-indexes or the raptor-editor ones. Think we will close this issue unless its an ongoing problem for you

zmilan commented 9 years ago

Hi @deeknow , I was solve it with just commented out that line (27437) in raptor.js and raptor.min.js. I know that is not good practice, but I not found any other solution in that moment. From my point of view, if no one else complain of this, than this is issue with my specific project/need, so feel free to close this issue. Thanks for asking.

deeknow commented 9 years ago

Thanks so much for replying @zmilan - glad to hear you have a workaround. It's always quite tricky dealing with z-indexes when combining multiple projects together.

zmilan commented 9 years ago

@deeknow you are welcome. Yes, it can be tricky and specially when !important is in use. For my project need, this was enough good patch, but i suppose it will not be good for some other needs.

deeknow commented 8 years ago

Thanks @zmilan - closing for now