PANmedia / raptor-editor

Raptor, an HTML5 WYSIWYG content editor!
www.raptor-editor.com
GNU General Public License v3.0
533 stars 136 forks source link

"Discontiguous selection is not supported error" in Chrome #182

Open deeknow opened 9 years ago

deeknow commented 9 years ago

(customer report) "You might want to warn users about this. Relevant to 'Range.detach' is now a no-op, as per DOM" and "Discontiguous selection is not supported." errors when loading a page with 0 dependecies package"

deeknow commented 9 years ago

Reopening issue which was reported in #176 originally. Testing showed the error was presenting itself in Chrome only. Recommended fix is to update the Rangy JS lib as the author has now implemented a solution for the Chrome behaviour (which is apparently throwing an error when it shouldn't)

fix will be applied to the raptor-dependencies repo which is cloned as part of the standard raptor-editor build process

Petah commented 9 years ago

https://github.com/PANmedia/raptor-editor/issues/176

deeknow commented 9 years ago

thanks Petah: going to push the 1.3 final release of Rangy to the dependencies sub-project

Petah commented 9 years ago

It wont work out of the box as there was some mods made to Rangy

deeknow commented 9 years ago

There's no history of the mods by you in the -dependencies project. Realise this was awhile ago but any idea when it was roughly that the rangy code was last pulled from Tim. I see there's a build date of 22/Feb/2014 but don't see a tagged release from him at that time for 1.3a, maybe some of the history got lost when his project was migrated over from Google code? Would be great to get a date then we could do a diff and see what was changed by you, that way Rangy can move forward in future if required.

Petah commented 9 years ago

Here is some of them: https://github.com/PANmedia/raptor-editor/commits/master/src/dependencies/rangy/rangy-cssclassapplier.js

The raptor-dependencies repo was split out of the main repo, so log will be in there if you search for them.

There is also this: https://github.com/PANmedia/raptor-dependencies/blob/master/rangy/rangy-applier.js which I think might have been custom, not sure though. Not sure where/if its used either.

deeknow commented 9 years ago

Great stuff. I'll take a squiz and see how much effort is required to patch that over the 1.3.0 final release. And yeah rangy-applier looks to be based on cssapplier but is a new custom file altogether so I'll assume it can be left as is for now. Thanks again.

Gregg8 commented 8 years ago

Any progress on this? The error can cause issues if you have unhandled exception detection software that logs to a third party service. You end up getting many unnecessary log entries. Any work arounds apart from patching the code would be greatly appreciated.