search

PASSIONLab / CombBLAS

The Combinatorial BLAS (CombBLAS) is an extensible distributed-memory parallel graph library offering a small but powerful set of linear algebra primitives specifically targeting graph analytics.
Other
59 stars 20 forks source link

Release version in CMake #16

Closed sagitter closed 1 year ago

sagitter commented 2 years ago

Hi all.

Why current CombBLAS version is still 1.16.0? https://github.com/PASSIONLab/CombBLAS/blob/v2.0.0/CMakeLists.txt#L2

drew-parsons commented 1 year ago

Is the new 2.0.0 release binary (ABI) compatible with the old 1.16 library? That doesn't seem likely. Should a new v2.0.1 tag be made fixing the version number in CMakeLists.txt ?

aydinbuluc commented 1 year ago

It is just a leftover line in the CMakeList. It should have said 2.0.0 Happy to accept a pull request if that creates issues.

drew-parsons commented 1 year ago

I've created PR #18 to fix this.

drew-parsons commented 1 year ago

There is a related question: are CombBLAS shared libraries expected to be ABI stable? i.e. is v2.0.1 (or v2.1.0) expected to be binary compatible with v2.0.0 ?

If that's the case then it could be helpful to configure CMakeFiles.txt to set the SOVERSION for shared libaries. This can be done separately from the project version.

By default the soname is set using the project version, but this might be overkill, since it means v2.0.1 would be treated as binary incompatible with v2.0.0.