search

PASTA-ELN / pasta-eln

PASTA-ELN with new frontend
https://pasta-eln.github.io/pasta-eln/
Other
8 stars 2 forks source link

Export: you have to specify what you want to export #285

Closed SteffenBrinckmann closed 4 months ago

SteffenBrinckmann commented 4 months ago

@jmurugan-fzj This is complete from my side: I do not understand why the test fails. Can you help?

jmurugan-fzj commented 4 months ago

@jmurugan-fzj This is complete from my side: I do not understand why the test fails. Can you help?

@SteffenBrinckmann This is failing due to the changes you made in exportELN siganture in the previous PR, I shall create a new PR for the tests today, give me sometime (y)

SteffenBrinckmann commented 4 months ago

@jmurugan-fzj Then we would merge both PRs at the same time? Or would it be better to merge this PR, then you create a new PR, which we merge thereafter?

jmurugan-fzj commented 4 months ago

@jmurugan-fzj Then we would merge both PRs at the same time? Or would it be better to merge this PR, then you create a new PR, which we merge thereafter?

@SteffenBrinckmann Could you please review my PR quickly, this will fix the pytest errors and you can work on the pylint errors as part of this PR or separately...!

SteffenBrinckmann commented 4 months ago

@jmurugan-fzj now it should be good

jmurugan-fzj commented 4 months ago

@jmurugan-fzj now it should be good

@SteffenBrinckmann Could you address the comments also quickly?

SteffenBrinckmann commented 4 months ago

@jmurugan-fzj Sorry, I had overlooked those. Thanks, they made much sense.