PASTA-ELN / pasta-eln

PASTA-ELN with new frontend
https://pasta-eln.github.io/pasta-eln/
Other
7 stars 2 forks source link

Dataverse metadata autoselected #314

Open HTsybenko opened 2 weeks ago

HTsybenko commented 2 weeks ago

When browsing through the Dataverse metadata editor, selecting some metadata definitions would also automatically pre-select their values, if there is a list to select from (see examples below).

This way, they would also appear in the metadata summary, and also will be automatically added to the uploaded dataset.

Most of the time, however, all these metadata definitions are not needed for the upload. The user then has to delete them manually by clicking the "Delete" button on the right from the editing field, which is rather time-consuming. In addition, some metadata cannot be removed at all, since the Delete button is not active, e.g., Date of Deposit and Distribution Date in Citation metadata.

I suggest that upon selecting the metadata definition, no value for it should be pre-selected in the list.

Screenshot from 2024-07-08 13-43-54 Screenshot from 2024-07-08 13-42-48 Screenshot from 2024-07-08 13-42-38 Screenshot from 2024-07-08 13-42-24 Screenshot from 2024-07-08 13-42-08 Screenshot from 2024-07-08 13-41-59 Screenshot from 2024-07-08 13-41-50 Screenshot from 2024-07-08 13-41-43 Screenshot from 2024-07-08 13-41-35 Screenshot from 2024-07-08 13-41-01 Screenshot from 2024-07-08 13-40-43 Screenshot from 2024-07-08 13-39-58 Screenshot from 2024-07-08 13-38-58 Screenshot from 2024-07-08 13-38-50 Screenshot from 2024-07-08 13-38-41 Screenshot from 2024-07-08 13-38-29 Screenshot from 2024-07-08 13-38-15 Screenshot from 2024-07-08 13-37-55

HTsybenko commented 2 weeks ago

A related issue: 1) Add some metadata in the Full list, and then switch to the Minimal list, add some metadata values there too. 2) Click Save and view the Metadata Summary.

The metadata from the Full list will be also displayed there and would also be added upon upload. This is not expected. If user selects the Minimal list, only those metadata should be saved and uploded.

jmurugan-fzj commented 2 weeks ago

@HTsybenko This happens only when the user select that particular item from the list right? By default whenever a combo-list is displayed to the user once when he selects it, the first item is selected by default. Hence the behavior you seen in the application. Do you suggest to keep an empty item as the first one in the list always if nothing set before already? For every required primary fields, the delete button is disabled hence the case for "Date of Deposit", but need to see if the QDateEdit allows to clear the value or not!

For the second part, that's the behavior presently that all the edits across the "minimal" and "full" are preserved before the save click, do you want it differently? So you mean to reset all the edits between the "minimal" & "full" switches? So the behavior should be like the following?

Is this the expected behavior? In my opinion, I would assume to preserve all the edits between minimal and full, because minimal is only a way of displaying the required fields from the full list! Just an easy way to set the needed items while doing the edits! Let me know your opinion..

HTsybenko commented 2 weeks ago

@HTsybenko This happens only when the used select that particular item from the list right? By default whenever a combo-list is displayed to the user once when he selects it, the first item is selected by default. Hence the behavior you seen in the application. Do you suggest to keep an empty item as the first one in the list always if nothing set before already? For every required primary fields, the delete button is disabled hence the case for "Date of Deposit", but need to see if the QDateEdit allows to clear the value or not!

@jmurugan-fzj Exactly, when the metadata category, such as Language, is selected, the first item "Abkhaz" will be selected there automatically. An empty item would definitely make more sense. For the required fields, one receives a message anyway, if those are not filled, so an empty item would work there as well.

For the second part, that's the behavior presently that all the edits across the "minimal" and "full" are preserved before the save click, do you want it differently? So you mean to reset all the edits between the "minimal" & "full" switches? So the behavior should be like the following?

  • User done some edits on "minimal" items and now user switches to "full", then user do some "full" edits. When user clicks on "Save" button, the edits from "full" edits should be only persisted?
  • Similarly the other way, User done some edits on "full" items and now user switches to "minimal", then user do some "minimal" edits. When user clicks on "Save" button, the edits from "minimal" edits should be only persisted?

Is this the behavior expected? In my opinion, I would assume to preserve all the edits between minimal and full, because minimal is only a way of displaying the required fields from the full list! Just an easy way to set the needed items while doing the edits! Let me know your opinion..

Here, I would expect that by selecting "minimal" or "full", the user decides which set of metadata has to be posted. In principle, the edits across "minimal" and "full" should be preserved, but if in the editing window, the "minimal" is selected in the top field, then upon clicking "save", only the terms from "minimal" should be used for the upload.

jmurugan-fzj commented 2 weeks ago

@HTsybenko But when you successfully save something the whole editor will be closed, then the user will not get a chance to save the modified edits in the other list!! So you want to change this behavior also that the "Save" click should not close the editor and to only allow the user to close the editor when the user clicks "close" or "cancel" button?

HTsybenko commented 2 weeks ago

@jmurugan-fzj I'm not sure I fully understand this problem. Currently, I can open the metadata editor, edit fields, then click "save". After saving, "Metadata Summary" appears, which shows all the metadata that will be posted during upload. Afterwards, I click "Yes", which closes the editor. Then, I select the projects and start my upload.

Later on, when I opened the metadata editor again, all the fields that were edited before (both in Full and Minimal) contained that previously edited metadata, which was expected.

So the "Save" would still save all the edited fields as before, but the "Full" or "Minimal" should decide what fields appear in the "Metadata Summary" and will be posted during upload.

jmurugan-fzj commented 2 weeks ago

@HTsybenko See the following steps:

So the user does not get a chance to summarize and save the edits in the "minimal" list, don't you see this as a problem?

HTsybenko commented 1 week ago

We agreed to change the displayed presets in the top field of the metadata editor to "Display full" and "Display minimal" and discuss remaining issues later.