search

PATRIC3 / patric3_website

Legacy PATRIC Website (JBoss Portal Version)
MIT License
5 stars 2 forks source link

PFS heat map: colors are wrong when reset filter is applied #1104

Closed mshukla1 closed 7 years ago

mshukla1 commented 8 years ago

Borrelia -> protein families tab -> keyword filter -> "ase" -> heatmap

shows bright yellow color for cells with only one member.

Now, reset filter using left panel.

Notice the color of the cells with one member -> it is dark yellow, the one used for showing two members.

screen shot 2016-10-17 at 4 21 58 pm
hyoo commented 7 years ago

This is a heatmap player(flash player) bug, I guess. Production server also has this problem (when it renders pgfam).

image

hyoo commented 7 years ago

I personally don't think this is a release blocker, because this problem exist in the current production site. This is a problem of flash implementation, which we don't have a control.

rkenyon commented 7 years ago

I just repeated the steps Maulik had and did not have the problem All colors rendered as they were supposed to. screen shot 2016-12-01 at 12 26 26 pm

hyoo commented 7 years ago

this real issue is a little bit off from this topic. After data update, now it is very difficult to reproduce it, but I can still see it when I connect to chestnut, ANL solr instance we copied before the update.

image

as far as I can tell, if we have a certain data (one cell has 70), it messes up heatmap color: turn yellow (which represents 1) into orange (which represent 2), which make us unreliable on color representations.

this can happen to any dataset even though we cannot find it easily.

hyoo commented 7 years ago

a few more screen shots.

image

image

rkenyon commented 7 years ago

I agree that if this issue is present on current Production, it is not "critical" for the Beta to Production release. Please downgrade it to just bug.

Ron

On 12/1/16 1:02 PM, hyoo wrote:

a few more screen shots.

image https://cloud.githubusercontent.com/assets/1236467/20805745/b06bcb74-b7bd-11e6-921b-51c11f2101b0.png

image https://cloud.githubusercontent.com/assets/1236467/20805761/be28d860-b7bd-11e6-9008-cc79117fcbad.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/PATRIC3/patric3_website/issues/1104#issuecomment-264246406, or mute the thread https://github.com/notifications/unsubscribe-auth/ADCnWuIzMRbrugK02-g2vncPY5fr1UTPks5rDwulgaJpZM4KZH6K.Web Bug from https://github.com/notifications/beacon/ADCnWte19zV44vC3g9OV7QQLScV5-Cehks5rDwulgaJpZM4KZH6K.gif

-- Ron Kenyon PATRIC Project Manager, patricbrc.org Project Director, Biocomplexity Institute Virginia Tech rkenyon@vbi.vt.edu

hyoo commented 7 years ago

I made an workaround and this seems working. available on alpha.

@mshukla1 please verify.