PATRIC3 / patric3_website

Legacy PATRIC Website (JBoss Portal Version)

MIT License

5 stars 2 forks source link

Protein Family names not being displayed on Protein Family page #1313

Closed ARWattam closed 7 years ago

ARWattam commented 7 years ago

I am comparing 3 groups and I chose PLFams. When the page loaded (FINALLY loaded), some of the protein families do not have names:

mshukla1 commented 7 years ago

This is data problem. I am working on it. Should be fixed soon.

ARWattam commented 7 years ago

there are some issues with displaying the family id as well. Look at the second row down.

mshukla1 commented 7 years ago

is this for public or private genome? can you send me the url, si I can verify when fixed?

ARWattam commented 7 years ago

I was comparing groups using the protein family sorter. One is a private genome, the rest are public.

----- Original Message ----- From: "Maulik Shukla" notifications@github.com To: "PATRIC3" patric3_website@noreply.github.com Cc: "Rebecca Wattam" wattam@vbi.vt.edu, "Author" author@noreply.github.com Sent: Tuesday, November 29, 2016 2:01:36 PM Subject: Re: [PATRIC3/patric3_website] Protein Family names not being displayed on Protein Family page (#1313)

is this for public or private genome? can you send me the url, si I can verify when fixed?

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/PATRIC3/patric3_website/issues/1313#issuecomment-263664913

mshukla1 commented 7 years ago

Try it again, and see if the blank product names are gone now.

ARWattam commented 7 years ago

Still getting the error:

Also seeing a protein family named 12

ARWattam commented 7 years ago

Also some oddly named FIGFams

hyoo commented 7 years ago

Per Bob's comment, "Veronika fixed these assignments in September and they are gone in the new families."

1046

mshukla1 commented 7 years ago

The problems with the PL and PGfams have been fixed.

There is not much we can do about the odd figfam product names as they are no longer maintained / updated. Also, they do not get synced with the annotation updates, so the function of the figfams might be inconsistent with the function of its members.

When we released Pattyfams, we kept figfams to give people time to transition to new families. Given it has been more than a year now, I propose that we get rid of figfams in the next release.