PATRIC3 / patric3_website

Legacy PATRIC Website (JBoss Portal Version)
MIT License
5 stars 2 forks source link

Filtering on Protein Family sorter is broken #1751

Closed ARWattam closed 6 years ago

ARWattam commented 7 years ago

From my genome group (but I also did it from the genus Bartonella), I tried to use the filtering function at the bottom of the filter. First, I could see that there were protein families that met the requirement I wanted (families with both 58 and 57 protein families per group.

screen shot 2017-10-12 at 10 13 44 am

then I selected the filter options for number of proteins per family

screen shot 2017-10-12 at 10 14 00 am

And this returned no results, even though I had checked previously to verify that protein families meeting this criterion exist

screen shot 2017-10-12 at 10 14 12 am

I also tried the filter on the number of genomes per family, being careful to choose filtering criteria that I knew matched the data

screen shot 2017-10-12 at 10 14 33 am

And once again, it returned nothing

screen shot 2017-10-12 at 10 14 41 am

I'm sure that this was working earlier this week.

hyoo commented 7 years ago

because, > 58 and < 57 is empty set.

mshukla1 commented 7 years ago

Harry, please add a check condition on user input and swap the values if min > max.

This will make the filter more robust and avoid such user mistakes.

-Maulik