PATRIC3 / patric3_website

Legacy PATRIC Website (JBoss Portal Version)
MIT License
5 stars 2 forks source link

No link to view CGA genome from jobs page #2024

Open ARWattam opened 6 years ago

ARWattam commented 6 years ago

There is no link to the genome landing page from the job page for genomes that were annotated in the Comprehensive Genome Analysis service. You have do double click on annotation, and then the view icon is visible in the next page. There should be a view icon in the vertical green bar of the first page when the annotation is highlighted from the jobs page

screen shot 2018-07-09 at 4 11 30 pm
olsonanl commented 6 years ago

This is a GUI issue to make the view links to the annotation job visible from the CGA page.

ARWattam commented 6 years ago

Check the tutorial to see how I had to do it. Its not intuitive at all.

On Thu, Jul 12, 2018 at 9:42 AM, olsonanl notifications@github.com wrote:

This is a GUI issue to make the view links to the annotation job visible from the CGA page.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PATRIC3/patric3_website/issues/2024#issuecomment-404516400, or mute the thread https://github.com/notifications/unsubscribe-auth/AK8ZdKLJn-SuyqGL81lo38MRaj2n_5QJks5uF1JigaJpZM4VIUdE .[image: Web Bug from https://github.com/notifications/beacon/AK8ZdGqcNuizKbbdItwYERdua3KcLeq5ks5uF1JigaJpZM4VIUdE.gif]

olsonanl commented 6 years ago

Yup. It should get fixed.


From: ARWattam notifications@github.com Sent: Thursday, July 12, 2018 9:39 AM To: PATRIC3/patric3_website Cc: Olson, Robert D.; Assign Subject: Re: [PATRIC3/patric3_website] No link to view CGA genome from jobs page (#2024)

Check the tutorial to see how I had to do it. Its not intuitive at all.

On Thu, Jul 12, 2018 at 9:42 AM, olsonanl notifications@github.com wrote:

This is a GUI issue to make the view links to the annotation job visible from the CGA page.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PATRIC3/patric3_website/issues/2024#issuecomment-404516400, or mute the thread https://github.com/notifications/unsubscribe-auth/AK8ZdKLJn-SuyqGL81lo38MRaj2n_5QJks5uF1JigaJpZM4VIUdE .[image: Web Bug from https://github.com/notifications/beacon/AK8ZdGqcNuizKbbdItwYERdua3KcLeq5ks5uF1JigaJpZM4VIUdE.gif]

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/PATRIC3/patric3_website/issues/2024#issuecomment-404535528, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACDXIq4oWn7iROaGRO7uEwahSEEu2s4Aks5uF1-cgaJpZM4VIUdE.

hyoo commented 6 years ago

@zreyn @nconrad I guess this is due to the missing type while we're activating view button. If so, we should be able to fix it quickly. Can one of you check?

zreyn commented 6 years ago

I'm looking into this. The issue I'm running into is that the genome id is not in the metadata of the annotation job result object. It is in the metadata of the children objects (which is how the blue 'eye' button gets it's path).

So, I see two options: 1) We make a separate call to the workspace manager to get the child objects' metadata and sift through it to get the genome id to populate the link. 2) We bubble up the metadata at some earlier stage in the objects' lifecycle.

I prefer option 2 because option 1 may misbehave when the workspace call is slower than the user to click that button.

zreyn commented 6 years ago

Option 2 would also fix #1658

dawenx commented 5 years ago

I will take a look on this...

mshukla1 commented 5 years ago

@dawenx Please add links to the following at the top right.

  1. FullGenomeReport.html
  2. Genome overview page
dawenx commented 5 years ago

I think I got this one fixed in my local dev and I just wanted to confirm before I go ahead to check in. I followed @mshukla1 and added icons/links on top right (see below screenshot). Note that this is slightly different from @ARWattam 's original request, i.e., adding an icon to vertical green bar for genome overview page.

Screen Shot 2019-08-16 at 3 41 04 PM

dawenx commented 5 years ago

View button (for genome overview page) and Report button (w/ a different icon) for full genome report are added. this fix is in PR 915.

dawenx commented 4 years ago

@ARWattam i know it has been for a while, but this issue has been fixed. please verify it on alpha and close the ticket if you are OK with it.