PATRIC3 / patric3_website

Legacy PATRIC Website (JBoss Portal Version)
MIT License
5 stars 2 forks source link

Service pages w/o login are confusing/problematic #2031

Closed dawenx closed 5 years ago

dawenx commented 6 years ago

Previously, if a user is not logged in and tries to access any service, a login form was displayed. It looked like we did some changes lately and it's confusing/problematic for some services now:

As today (07/13/2018), when a user is not logged in, we show log in form for 12 of them (16 services in total). There are 4 services (BLAST, Similar Genome Finder, Protein Family Sorter and Comparative Pathway Tool) that can be seen without login, but all workspace object related inputs are broken. See below screen shot for Similar Genome Finder service. service_wo_login

rkenyon commented 6 years ago

Actually, I believe that we would like to get to the point where all service submission forms without logging in, but that the form is disabled (except for links to User Guides and Tutorials) in some consistent way and there is a clear message that login is required to use the service.

The rationale for this is that, for a new non-logged in user, it is jarring and a bit frustrating to get a generic login form when you click on any of the services. If the user can see something about what the service is and does before they have to (create a) login, it would be more user-friendly.

Ron

On Fri, Jul 13, 2018 at 11:40 AM Dawen Xie notifications@github.com wrote:

Previously, if a user is not logged in and tries to access any service, a login form was displayed. It looked like we did some changes lately and it's confusing/problematic for some services now:

As today (07/13/2018), when a user is not logged in, we show log in form for 12 of them (16 services in total). There are 4 services (BLAST, Similar Genome Finder, Protein Family Sorter and Comparative Pathway Tool) that can be seen without login, but all workspace object related inputs are broken. See below screen shot for Similar Genome Finder service. [image: service_wo_login] https://user-images.githubusercontent.com/26723038/42700246-25c687c6-8691-11e8-987d-bb2e69f537fa.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/PATRIC3/patric3_website/issues/2031, or mute the thread https://github.com/notifications/unsubscribe-auth/ADCnWlEkC5kNmRr5675A4JT4ucz52p1Iks5uGL9dgaJpZM4VPGVC .[image: Web Bug from https://github.com/notifications/beacon/ADCnWl4ESzmr1NewmISDNxXIZvW-pihJks5uGL9dgaJpZM4VPGVC.gif]

-- Note: My email has changed to rkenyon@bi.vt.edu.

Ron Kenyon, Project Director Biocomplexity Institute of Virginia Tech PATRIC Project Manager www.patricbrc.org rkenyon@bi.vt.edu

dawenx commented 6 years ago

@rkenyon I remember the discussion on this. But what we are showing on the production right now is more confusing IMHO. For example, the screen shot I attached shows a broken interface for uploading FASTA. And somewhat surprisingly, user now can use this service without logging in.

rkenyon commented 6 years ago

Yes, what is on production is confusing. I'm just suggesting where we want to go, ultimately.

On Fri, Jul 13, 2018 at 1:22 PM Dawen Xie notifications@github.com wrote:

@rkenyon https://github.com/rkenyon I remember the discussion on this. But what we are showing on the production right now is more confusing IMHO. For example, the screen shot I attached shows a broken interface for uploading FASTA. And somewhat surprisingly, user now can use this service without logging in.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PATRIC3/patric3_website/issues/2031#issuecomment-404898490, or mute the thread https://github.com/notifications/unsubscribe-auth/ADCnWiVsp2ihAGh-bYHf3FK2Py8knCtrks5uGNdNgaJpZM4VPGVC .[image: Web Bug from https://github.com/notifications/beacon/ADCnWiIwGxzNykMSNRx7todz3JJIu5Gyks5uGNdNgaJpZM4VPGVC.gif]

-- Note: My email has changed to rkenyon@bi.vt.edu.

Ron Kenyon, Project Director Biocomplexity Institute of Virginia Tech PATRIC Project Manager www.patricbrc.org rkenyon@bi.vt.edu

dawenx commented 5 years ago

i have a discussion with @dmachi today and i will work on this. when a service requires login and the user is not logged in, the plan is to show service description, links to user guide and tutorial and a login form; everything else will be the same as before. this requires change on AppBase and all service apps.

dawenx commented 5 years ago

@rkenyon this is done and on alpha now, please verify, thanks

rkenyon commented 5 years ago

I checked all the links and mostly they look good, except for the following.

  1. Metagenomic Binning Service needs a better introduction. Please use the following:

The Metagenomic Binning Service accepts either reads or contigs, and attempts to "bin" the data into a set of genomes. This service can be used to reconstruct bacterial and archael genomes from environmental samples. For further explanation...

  1. Model Reconstruction Service needs a better introduction. Please use this:

The Model Reconstruction Service integrates and augments technologies for genome annotation, construction of gene-protein-reaction (GPR) associations, generation of biomass reactions, reaction network assembly, thermodynamic analysis of reaction reversibility, and model optimization, to generate draft genome-scale metabolic models. The service is capable of generating functioning draft metabolic models of an organism starting from an assembled genome sequence. For further explanation...

  1. ID Mapper Service seems to be using the form information for Proteome Comparison Service

[image: Screen Shot 2018-09-18 at 1.44.56 PM.png]

  1. The "i" button on Metagenomic Binning Service (logged in) is missing.

Ron

On Tue, Sep 18, 2018 at 1:27 PM Dawen Xie notifications@github.com wrote:

@rkenyon https://github.com/rkenyon this is done and on alpha now, please verify, thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PATRIC3/patric3_website/issues/2031#issuecomment-422479166, or mute the thread https://github.com/notifications/unsubscribe-auth/ADCnWk0KU9Bg3C7u4fA3mxCLVlYfkrSGks5ucSzsgaJpZM4VPGVC .

-- Note: My email has changed to rkenyon@bi.vt.edu.

Ron Kenyon, Project Director Biocomplexity Institute of Virginia Tech PATRIC Project Manager www.patricbrc.org rkenyon@bi.vt.edu

dawenx commented 5 years ago

@rkenyon thanks for your comments, i have addressed all except item 3 ( and it is because we currently don't have a tutorial for ID Mapper service). i have set the URL to tutorial index page for now, will update it when Rebecca creates one.

@hyoo i submitted a new PR, are you planning to push it to production in near future? it will address the progressive refinement issue in tree service as well.

rkenyon commented 5 years ago

@dawenx I have added a stub page for the ID Mapper Service tutorial. Please change the tutorial link to this: https://docs.patricbrc.org/tutorial/id_mapper/id_mapper.html

dawenx commented 5 years ago

Look like the link is not available before the nightly auto build, but i went ahead to update it in the service.

rkenyon commented 5 years ago

Thanks. Yes, it will be available after 4PM our time today.

hyoo commented 5 years ago

i have refreshed the doc site, and should be available now. please check.

rkenyon commented 5 years ago

Verified. Working correctly.

Ron

On Thu, Sep 20, 2018 at 3:34 PM hyoo notifications@github.com wrote:

i have refreshed the doc site, and should be available now. please check.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PATRIC3/patric3_website/issues/2031#issuecomment-423305853, or mute the thread https://github.com/notifications/unsubscribe-auth/ADCnWnZ1vHKpJ_VKaPBcy4aiqI8d_BK0ks5uc-2jgaJpZM4VPGVC .

-- Note: My email has changed to rkenyon@bi.vt.edu.

Ron Kenyon, Project Director Biocomplexity Institute of Virginia Tech PATRIC Project Manager www.patricbrc.org rkenyon@bi.vt.edu

dawenx commented 5 years ago

@hyoo i forgot to add tutorial icon/link to ID Mapper service in its logged in form. i just fixed it and submitted one more PR. sorry about the extra work.

dawenx commented 5 years ago

above problem is not related to this issue and there's no harm to delay adding the link to a placeholder, i will close the ticket.