Closed GoogleCodeExporter closed 8 years ago
Sorry, the patch wasn't complete. Here is the complete patch.
Original comment by valentin.blot0@gmail.com
on 4 Jan 2011 at 12:37
Attachments:
Original comment by neilboyd
on 4 Jan 2011 at 9:50
The one downside is that we have to include the sqlite jar file which adds some
size to the distribution. It's not a lot, but it would be nice to not have to
include it. If there is some way to compile without the sqlite jar and require
the end-user to add it to their project if they want to use it. If it's not
present, then the class will just throw an exception at runtime and tell the
user that it is missing. I don't know if this is possible.
And I'm not trying to deflect usage of this - personally, I think using the DB
is a good idea assuming there isn't too much of a performance hit - but I worry
that unless the offline map tools embrace the "db as a storage mechanism", this
may be just a niche provider that doesn't get widespread use. Again, these are
just my thoughts - in the end, it's better if we include it than not!
Original comment by kurtzm...@gmail.com
on 5 Jan 2011 at 4:02
I agree with Marc. I was thinking of implementing this patch, but not adding it
to the default provider chain.
I'm also tending to move away from the tile packager in favour of Mobile Atlas
Creator.
Original comment by neilboyd
on 5 Jan 2011 at 6:32
I agree. Remark however that the jar file is not included in the osmdroid
library (the one which is on the phone), but only in the packager jar.
But indeed I would be glad to integrate it as a new output for Mobile Atlas
Creator. I will try to propose a patch on the sourceforge of the project.
The thing is that without any way to create the db files, the patch is useless
in osmdroid library, so integrating it to the packager was the first step,
waiting for this to be integrated in Mobile Atlas Creator.
Anyway, did you try it ? What do you think ?
Original comment by valentin.blot0@gmail.com
on 5 Jan 2011 at 11:23
Please have a look at revision 680. It should now be easier to do this in a
similar way to ZipFileArchive.
Original comment by neilboyd
on 6 Jan 2011 at 11:28
I've committed the packager parts in revision 682.
Original comment by neilboyd
on 6 Jan 2011 at 11:55
[deleted comment]
It was trivial to implement this like I said in comment 6 - done in revision
683.
I haven't tested this at all.
Original comment by neilboyd
on 6 Jan 2011 at 12:08
Original comment by neilboyd
on 6 Jan 2011 at 12:09
The developer from mobile atlas creator pointed out that the key calculation
could produce an overflow on high zoom levels, so we should use a "long"
instead of an "int". Here is the corresponding patch.
Original comment by valentin.blot0@gmail.com
on 10 Jan 2011 at 1:11
Attachments:
Committed in revision 708. Good to see it's getting into Mobile Atlas Creator.
Original comment by neilboyd
on 11 Jan 2011 at 9:19
Done, it's now in Mobile Atlas Creator (in the latest alpha version).
Original comment by valentin.blot0@gmail.com
on 15 Jan 2011 at 4:42
So, does it work? Are we finished? Can I close this now?
Original comment by neilboyd
on 15 Jan 2011 at 9:21
I think so, I didn't make lots of tests but until now it seems to work
perfectly. The only thing now is to update the wiki page MobileAtlasCreator in
order to tell that you can also create databases.
Original comment by valentin.blot0@gmail.com
on 17 Jan 2011 at 11:34
Which version of MAC do I need, and what's the name of the Atlas format?
Original comment by neilboyd
on 18 Jan 2011 at 9:06
You need the latest alpha version :
http://sourceforge.net/projects/trekbuddyatlasc/files/Alpha%20and%20experimental
/MOBAC%201.9%20preview%204.zip/download and you have to chose the "osmdroid
sqlite" format.
Original comment by valentin.blot0@gmail.com
on 18 Jan 2011 at 7:48
Original comment by neilboyd
on 18 Jan 2011 at 8:45
Original issue reported on code.google.com by
valentin.blot0@gmail.com
on 4 Jan 2011 at 12:31Attachments: