Patch for /trunk/osmdroid-android/src/org/osmdroid/tileprovider/modules/MapTileDownloader.java

[GoogleCodeExporter]

openStream() -> HttpClient

Original issue reported on code.google.com by 828...@gmail.com on 12 Apr 2011 at 12:38

• Merged into: #212

Attachments:

• MapTileDownloader.java.patch

[GoogleCodeExporter]

Additional modifications

change in:
trunk/osmdroid-android/src/org/osmdroid/tileprovider/modules/TileWriter.java

add class:
trunk/osmdroid-android/src/org/osmdroid/tileprovider/modules/SizedBitmapDrawable
.java

change in:
trunk/osmdroid-android/src/org/osmdroid/tileprovider/modules/IFilesystemCache.ja
va

Original comment by 828...@gmail.com on 12 Apr 2011 at 12:44

Attachments:

• IFilesystemCache.java
• TileWriter.java

[GoogleCodeExporter]

The patch looks good, but how do I apply it?
Please could you do a svn patch, or just attach MapTileDownloader.java.

Original comment by neilboyd on 14 Apr 2011 at 3:10

• Changed state: Accepted

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

I made many changes in the project so it will be easier to pour the entire 
tileprovider folder with MapTileDownloader.java and dependency

Original comment by 828...@gmail.com on 15 Apr 2011 at 6:58

Attachments:

• tileprovider.tar

[GoogleCodeExporter]

As you said, there's lots of changes in this patch, including the patch for 
issue 196.

I'd much prefer it if you made one patch per change.  The title of this issue 
is not very descriptive, but the description is.

Perhaps you could get yourself made as a committer, and commit each change 
individually.

Original comment by neilboyd on 18 Apr 2011 at 2:55

[GoogleCodeExporter]

Thank you for submitting these patches. Like Neil said, it's always best to 
keep patches (and their supporting issue tickets) separate. I know that's hard 
when the patches start to pile up and we haven't had time to integrate them. We 
appreciate your patience.

As Neil suggested, this is best broken up into separate patches. I have spun 
three patches out of your changes:

1. Adding try/finally blocks around locking operations.

2. Implementing HttpClient in the tile downloader

3. Switching to an Executor/thread pool

I wasn't too clear on some of the other changes, so if you think they should be 
considered, please resubmit as a separate patch.

I am going to apply #1 right away, and spin #2 and #3 off as separate tickets 
since they are significant changes.

Original comment by kurtzm...@gmail.com on 15 May 2011 at 10:45

[GoogleCodeExporter]

This has been spun off into Issue 212 and 213. Please direct all conversation 
to those tickets.

Original comment by kurtzm...@gmail.com on 15 May 2011 at 11:06

• Changed state: Duplicate