PATRIK27 / osmdroid

Automatically exported from code.google.com/p/osmdroid
0 stars 0 forks source link

LOWER_LEFT_CORNER Hotspot (Marker Positioning) wrong #275

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Add an item to itemizedOverlay and set Hotspot to LOWER_LEFT_CORNER
2. Look where the marker is set

What is the expected output? What do you see instead?
To have the marker set with the anchor point in the lower left corner - instead 
the icon is set somewhere completly wrong

What version of the product are you using? On what operating system?
3.0.6

Please provide any additional information below.
ItemizedOverlay.java # 277
Just have a look at these 2 cases in code:

        case LOWER_RIGHT_CORNER:
            mRect.offset(-markerWidth, -markerHeight);
            break;
        case LOWER_LEFT_CORNER:
            mRect.offset(0, markerHeight); /// TODO test - should this be -markerHeight ???

1) Someone already found the problem but didn't correct it because he/she was 
not sure.
2) that both lower hotspots can not have +markerheight and then -marker height 
should make clear that one of them must be wrong.
3) Lower_Left_Corner is wrong and needs to be -markerHeight

Original issue reported on code.google.com by abzy...@gmail.com on 11 Nov 2011 at 2:13

GoogleCodeExporter commented 8 years ago

Original comment by kurtzm...@gmail.com on 6 Apr 2012 at 9:00