PAYONE-GmbH / magento-1

PAYONE Payment Extension for Magento 1
22 stars 41 forks source link

Missing argument 1 for Payone_Core_Model_Mapper_ApiRequest_Payment_Authorize_Abstract::getNarrativeText() #17

Closed ernsto closed 7 years ago

ernsto commented 7 years ago

I get following message in the system.log when i use the credit card payment method. (I use PHP7)

2016-12-07T09:43:06+00:00 ERR (3): Warning: Missing argument 1 for Payone_Core_Model_Mapper_ApiRequest_Payment_Authorize_Abstract::getNarrativeText(), called in (...)/vendor/payone-gmbh/magento-1/app/code/community/Payone/Core/Model/Mapper/ApiRequest/Payment/Authorize/Abstract.php on line 156 and defined  in (...)/vendor/payone-gmbh/magento-1/app/code/community/Payone/Core/Model/Mapper/ApiRequest/Payment/Authorize/Abstract.php on line 769

Solution Edit the File app\code\community\Payone\Core\Model\Mapper\ApiRequest\Payment\Authorize\Abstract.php: Remove the line 766 and and the $type parameter from the getNarrativeText method. The $type parameter is not used.

Before: image

After: image

fjbender commented 7 years ago

Thanks for your input, we'll change it in the next version.