PAYONE-GmbH / magento-1

PAYONE Payment Extension for Magento 1
22 stars 41 forks source link

Missing files in 3.7.3 #21

Closed razbakov closed 7 years ago

razbakov commented 7 years ago

Please create a new version tag for current master

For example in 3.7.3 missing the following files in design folder:

fjbender commented 7 years ago

I'm sorry, I can't see the problem:

florian@charon:/tmp$ git clone https://github.com/payone-gmbh/magento-1
Klone nach 'magento-1' ...
remote: Counting objects: 3015, done.
remote: Total 3015 (delta 0), reused 0 (delta 0), pack-reused 3015
Empfange Objekte: 100% (3015/3015), 6.15 MiB | 1.76 MiB/s, Fertig.
Löse Unterschiede auf: 100% (1550/1550), Fertig.
Prüfe Konnektivität ... Fertig.
florian@charon:/tmp$ cd magento-1/
florian@charon:/tmp/magento-1 (master u=)$ git checkout v3.7.3
Note: checking out 'v3.7.3'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b <new-branch-name>

HEAD ist jetzt bei e135fec... Merge pull request #19 from fjbender/fjbender-patch-1
florian@charon:/tmp/magento-1 ((v3.7.3))$ cat app/design/frontend/base/default/template/payone/core/checkout/protect.phtml 
<?php
/**
 *
 * NOTICE OF LICENSE
 *
 * This source file is subject to the GNU General Public License (GPL 3)
 * that is bundled with this package in the file LICENSE.txt
 *
 * DISCLAIMER
 *
 * Do not edit or add to this file if you wish to upgrade Payone_Core to newer
 * versions in the future. If you wish to customize Payone_Core for your
 * needs please refer to http://www.payone.de for more information.
 *
 * @category        Payone
 * @package         design_frontend_base_default
 * @subpackage      template
 * @copyright       Copyright (c) 2012 <info@noovias.com> - www.noovias.com
 * @author          Matthias Walter <info@noovias.com>
 * @license         <http://www.gnu.org/licenses/> GNU General Public License (GPL 3)
 * @link            http://www.noovias.com
 */

/**
 * @var $this Mage_Core_Block_Template
 */
if (Mage::getStoreConfig('payone_protect/general/enabled') == 1)
{
    $url = Mage::helper('payone_core/url')->getMagentoUrl('payone_core/checkout_onepage/verifyPayment');

    ?>
<script type="text/javascript">
    //<![CDATA[
    Event.observe(window, 'load', function () {
        payment.saveUrl = '<?php echo $url ?>';
    });
    //]]>
</script>
<?php

}

Is there anything I'm missing?

razbakov commented 7 years ago

It is confusing. Now I see it. I checked with colleague 2h before and it wasn't there. Thank you for checking.