search

PAYONE-GmbH / magento-1

PAYONE Payment Extension for Magento 1
22 stars 40 forks source link

MAGE-456: Improve Transaction Status Handling #415

Closed p1fb closed 4 years ago

sprankhub commented 4 years ago

This looks quite promising - thanks!

BoulangerV commented 4 years ago

Hello, A comment regarding "This letter cannot be sent" error during sending.

To me, after investigation, it seems that the new email template is not registered into the config. So some preparation steps are skipped, then the subject is not processed, and finally the validation fails before sending.

FIX 1- Before this line : https://github.com/PAYONE-GmbH/magento-1/blob/cfbfcaae10affbd01bbf63da023aa6399ea06c88/app/code/community/Payone/Core/etc/config.xml#L358

we have to add : `

payone/core/transaction_status_error_report.phtml html ` 2- And on line : https://github.com/PAYONE-GmbH/magento-1/blob/cfbfcaae10affbd01bbf63da023aa6399ea06c88/app/code/community/Payone/Core/Model/Service/TransactionStatus/Execute.php#L305 We should replace "transaction_status_error_report" with "payone_transaction_status_error_report" Then it should be ok to try the email sending. No clue if the sending will go good afterwards, has to be tested :) Cheers, Vincent
sprankhub commented 4 years ago

What is the current status here? I would love to see this being merged ASAP :)

hreinberger commented 4 years ago

This PR is currently queued for testing by our QA. I've pushed it a bit higher since it's already quite old.