search

PAYONE-GmbH / magento-2

PAYONE Payment Extension for Magento 2
28 stars 56 forks source link

Tax percentage calculation for Creditmemos without products #320

Open theCapypara opened 4 years ago

theCapypara commented 4 years ago

If a Creditmemo does not contain any products, the generated debit request does not contain any tax percentage (va) for the shipping item.

The reason for this is, that the shipping and discount items get their va value from the first product's tax percentage. If none is set, the value remains false -> 0.

This Pull Request fixes this by falling back to reading the tax information from the order tax item table as a fallback, if the tax amount has not been initialized.

This is a draft, because we were not able to actually test it yet. I will report back when we successfully tested this in a customer installation.

fjbender commented 4 years ago

Thanks for your contribution! Looking forward to your feedback after the test.