search

PAYONE-GmbH / magento-2

PAYONE Payment Extension for Magento 2
28 stars 56 forks source link

Issue #348 is still not part of an official release #385

Closed andreasberenz closed 1 year ago

andreasberenz commented 3 years ago

After almost one year, I would expect, that this very important change is released. Every time we need to redeploy the vendor files this "wrong bahaviour" in our case is deployed and we have to patch this.

https://github.com/PAYONE-GmbH/magento-2/commit/174542c776d6ce82be6378cf20294dc50390aa9c

The commit message says, that it "needs further testing" but it was still selected for the release. In theory you have a solution, but you don't deploy it? Why?

I know good reasons why, because there is no good migration path for that and if you deploy the configuration option, every installation is facing again a change in the behaviour.

I would be fine with, if you make a migration, which enables this option by default to keep the current behaviour and we're able to disable this option in our next release. But if the codes stays like that, we will always have this misbehaviour and the damage if this issue is out of our scope.

Writing a custom module for this case, which corrects this for us, must be double checked as well every time there is a new release.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

hreinberger commented 2 years ago

unstaling this to investigate. We certainly need to fix this instead of keeping half-done code in here.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.