search

PAYONE-GmbH / magento-2

PAYONE Payment Extension for Magento 2
28 stars 56 forks source link

Birthday is not validated correctly #434

Closed torhoehn closed 2 years ago

torhoehn commented 2 years ago

While using PAYONE - Paysafe Pay Later™ Invoice we discovered that the birthday is not validated correctly.

The validation is implemented here: https://github.com/PAYONE-GmbH/magento-2/blob/master/view/frontend/web/js/view/payment/method-renderer/base.js#L106

E.g. it returns true for the following input: isBirthdayValid('32', '13', '75');

janteuber commented 2 years ago

Hello @torhoehn ,

Thank you for your message and also for your PR.

I will have our agency check this and give you feedback.

janteuber commented 2 years ago

Hello @torhoehn , We checked your PR and merged it. Thank you very much. Next release will be in May.