search

PAYONE-GmbH / magento-2

PAYONE Payment Extension for Magento 2
28 stars 56 forks source link

rely on proxy mode config only #450

Closed torhoehn closed 2 years ago

torhoehn commented 2 years ago

To transfer the correct IP address to Payone while using proxy mode, the function parameter has to be removed, due payment requests are calling this function without a parameter, this leads the problem that the IP of a loadbalancer is transferred to Payone: https://github.com/PAYONE-GmbH/magento-2/blob/master/Model/Api/Request/Genericpayment/PreCheck.php#L92 https://github.com/PAYONE-GmbH/magento-2/blob/master/Model/Api/Request/Authorization.php#L164 https://github.com/PAYONE-GmbH/magento-2/blob/master/Model/Api/Request/PaydirektAgreement.php#L82

If my assumption is correct the config for Proxy-Mode inside of Transaction-Status Processing should be moved to General -> Global Settings of the module, because it's used for Payment Requests and Transaction-Status Processing.

FatchipRobert commented 2 years ago

Thanks for your contribution. I adopted your changes and as suggested by you I moved the config option to the general configuration.

torhoehn commented 2 years ago

@FatchipRobert Maybe it would be easier if I apply your suggestion?

janteuber commented 2 years ago

Hello @torhoehn , I merged https://github.com/PAYONE-GmbH/magento-2/pull/454 from our Dev. Thank you for your pull request. We will publish our pullrequest with the next release at the end of September.