search

PAYONE-GmbH / shopware-5

PAYONE Payment Plugin for shopware 5
MIT License
10 stars 24 forks source link

Merge snippet folders to avoid filename conflicts #54

Closed nether-cat closed 7 years ago

nether-cat commented 7 years ago

There are two snippet folders in the same directory path:

Frontend/MoptPaymentPayone/Snippets Frontend/MoptPaymentPayone/snippets

That causes filename conflicts on case-insensitive filesystems (e.g. on Windows and macOS). I am suggesting to merge the two directories to avoid these conflicts.

fjbender commented 7 years ago

Good idea. Go ahead.

Can we address the deprecation of the "Default" snippet group when doing this? It's been on the list in SW-49 for quite some time now:

1) Shopware_Tests_Components_Snippet_SnippetStructureTest::testSnippetsShouldBeValid
Snippet validation errors detected: 
"Default" snippet group is deprecated (/home/florian/Dev/shopware/engine/Shopware/Plugins/Default/Frontend/MoptPaymentPayone/Snippets/frontend/MoptPaymentPayone/payment.ini)
[...]

This would enable us to run Unit Tests automatically through Travis, as this is the last issue blocking this.

fjbender commented 7 years ago

Fixed in #55.