search

PAYONE-GmbH / shopware-5

PAYONE Payment Plugin for shopware 5
MIT License
10 stars 24 forks source link

ERROR CheckoutFinish Subscriber getArrayCopy() #81

Closed SDJeff closed 7 years ago

SDJeff commented 7 years ago

If the UST ID Validation runs to timeout because f.e. the VATID portal is not reachable, at Shopware/Plugins/Community/Core/SwagVatIdValidation/Subscriber/CheckoutFinish.php at Line 71 you get NULL and the function fails.

$orderDetails = Shopware()->Session()->get('sOrderVariables')->getArrayCopy();

So the jump back to the shopware shop fails and independent if the payment was successful or not, the order is lost at the shop. Best case is payment failed too otherwise the customer paid and nobody will recognize that a new order ist there.

fjbender commented 7 years ago

Hi @SDJeff, Sorry for the delay in getting back to you.

Is there anything you'd suggest as a workaround? Is there any exception to catch, or how can we know the external service failed?

SDJeff commented 7 years ago

You can't know. But perhaps you can check sOrderVariables before getArrayCopy of NULL Values. Many customer's reporting us that there are trouble with the VATID portal at the moment.

fjbender commented 7 years ago

So how exactly should our plugin behave? If I understand correctly, this error occurs when we come back into the Shop from the payment method (e.g. PayPal), so the payment has already been authorized. I'm not sure if our plugin can do anything at this point to save the order. If so, I think this is a duplicate of #37.

fjbender commented 7 years ago

Closed as duplicated of #37