PAYONE-GmbH / shopware-6

PAYONE Payment Plugin for Shopware 6
MIT License
14 stars 19 forks source link

Use environment variables correct #243

Closed shyim closed 1 year ago

shyim commented 1 year ago

The plugin uses getenv to get the environment variable. This is totally wrong and the code should inject environment variables using DI with %env(APP_URL)% as example with an default set here

https://symfony.com/doc/current/configuration/env_var_processors.html

janteuber commented 1 year ago

Hello @shyim ,

Thanks for your message.

Our developers will take a look at the issue.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.