search

PAYONE-GmbH / shopware-6

PAYONE Payment Plugin for Shopware 6
MIT License
14 stars 19 forks source link

Ensure that environment variables are used correctly #271

Closed Be-njamin closed 11 months ago

Be-njamin commented 12 months ago

The issue: https://github.com/PAYONE-GmbH/shopware-6/issues/243 still persists. Unfortunately the original issue was marked as stale and closed. Could you please have another look at this?

The plugin uses getenv to get the environment variable. This is totally wrong and the code should inject environment variables using DI with %env(APP_URL)% as example with an default set here https://symfony.com/doc/current/configuration/env_var_processors.html

janteuber commented 11 months ago

Hello @Be-njamin , we solved that already in our existing 6.5 plugin