search

PAYONE-GmbH / shopware-6

PAYONE Payment Plugin for Shopware 6
MIT License
14 stars 19 forks source link

Add new shopware versions to git workflow #283

Closed momocode-de closed 7 months ago

momocode-de commented 9 months ago

@rommelfreddy Yes, I know that this has been added as of 6.5.4. By the way, you can also do EntityRepository<OrderCollection> instead of EntityRepository<EntityCollection<OrderEntity>>. I agree that we should do it this way, but shouldn't we do it in an extra PR for the whole code?

rommelfreddy commented 9 months ago

@rommelfreddy Yes, I know that this has been added as of 6.5.4. By the way, you can also do EntityRepository<OrderCollection> instead of EntityRepository<EntityCollection<OrderEntity>>. I agree that we should do it this way, but shouldn't we do it in an extra PR for the whole code?

yes, we could do this in a separate PR, but instead of adding legacy code, we could add better code ;-)

yes, i know that there are exist collection-models for some entities - but not for all - thats the reason why i added the long version