PBH-BTN / PeerBanHelper

自动封禁不受欢迎、吸血和异常的 BT 客户端,并支持自定义规则。PeerId黑名单/UserAgent黑名单/IP CIDR/假进度/超量下载/进度回退/多播追猎/连锁封禁/伪装检测 支持 qBittorrent/Transmission/Deluge/BiglyBT
GNU General Public License v3.0
539 stars 15 forks source link

Expression refactor #166

Closed Ghost-chu closed 1 week ago

Ghost-chu commented 1 week ago

Summary by CodeRabbit

coderabbitai[bot] commented 1 week ago

[!WARNING]

Review failed

The pull request is closed.

Walkthrough

These updates feature significant enhancements to the PeerBanHelper project, including version upgrades for various dependencies like JavaFX and Chromium, new repositories, and improved JavaFX integration. There's an emphasis on optimizing IP and peer management, introducing new methods for handling web views, and cache improvements for efficient peer address handling. New features include handling basic authentication and JavaScript callbacks for web views, new configuration scripts, and better support for banning peers based on rules and expressions.

Changes

Files/Paths Change Summary
pom.xml Dependency version upgrades, new repositories and profiles, added JavaFX and Chromium components.
BuildMeta.java, Main.java, PBHLibraryManager.java New fields, method updates, and library manager introductory and initialization changes.
PeerBanHelperServer.java Initialization improvements, error handling updates, and method refactoring for managing peers and modules.
ProfileUpdateScript.java New bigUpdate() method for configuration upgrades and error logging.
Downloader.java, DownloaderBasicAuth.java, WebViewScriptCallback.java New methods and imports for handling basic authentication and web view JavaScript callbacks.
.../downloader/impl/qbittorrent/QBittorrent.java Added methods and imports for basic authentication and web view handling.
SingleTorrentPeer.java, TRPeer.java Renamed getAddress method to getPeerAddress and added lazy initialization for peerAddress.
.../impl/transmission/Transmission.java Added new methods for authentication and web view handling, modified getTorrents method for new field inclusion.
JavaFxImpl.java, JavaFxWebViewWrapper.java Introduced and adjusted methods for web view handling, library loading, and event listener installation.
MainWindow.form, MainWindow.java Commented out old handling code, added new tab for JCEF, updated tabbedPaneWebView.
BanResult.java Updated constructor with @Nullable and @NotNull annotations for parameters.
AutoRangeBan.java, IPBlackList.java Method refactoring, cache improvements for handling IP address mappings, and optimized IP checks.
ExpressionRule.java New class extending AbstractRuleFeatureModule, handles scripting for peer banning with caching and metadata parsing.
thunder-check.av New script for detecting and blocking specific versions of XunLei (Thunder) client based on peer information.

Sequence Diagram(s)

sequenceDiagram
    participant Main as Main.java
    participant PBH as PBHLibraryManager.java
    participant Peer as PeerBanHelperServer.java
    participant Config as ProfileUpdateScript.java
    participant GUI as JavaFxImpl.java

    Main->>PBH: Initialize LibraryManager
    PBH->>PBH: Manage Libraries and Classpath
    Main->>Peer: Start Server
    Peer->>Config: Load Configuration
    Config->>Peer: Update Config if Necessary
    Peer->>GUI: Initiate JavaFX Web View
    GUI->>PBH: Load Web View Libraries
    GUI->>Main: Setup JavaFX Window
    Main->>Config: Handle Configuration Upgrade (if bigUpdate())

Poem

In lines of Java's coded prose,
A helper's craft and wisdom grows.
From JavaFX, a shine so bright,
To peer bans guiding through the night.
New scripts arise, old debtors owe,
In code's embrace, our changes show.
For every peer, beware the sting;
The guardian of the network sings.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.