Btn bloom

[PluieM]

使用bloom filter提高btn网络下发的ip规则匹配性能

Summary by CodeRabbit

• Enhancements

  • Improved null-safety across various classes and methods with the addition of @NotNull and @Nullable annotations.
  • Enhanced code clarity and robustness by specifying non-null requirements and allowing null values where applicable.

• Removed

  • Simplified directory setup in the Main class by removing the libraryDirectory variable.

These changes collectively enhance the application's stability and reliability by ensuring better handling of null values and clarifying method contracts.

[coderabbitai[bot]]

Walkthrough

The recent updates focus on enhancing null-safety within the codebase by adding @NotNull and @Nullable annotations. This improves the overall robustness and clarity of the parameters and return types across multiple classes. Several constructor and method parameters are now explicitly non-null, ensuring better data integrity and reducing the likelihood of NullPointerException occurrences.

Changes

File Path	Change Summary
src/main/java/com/ghostchu/peerbanhelper/BuildMeta.java	Added @NotNull to loadBuildMeta method parameter.
src/main/java/com/ghostchu/peerbanhelper/Main.java	Removed libraryDirectory variable declaration.
src/.../PeerBanHelperServer.java	Added @NotNull and @Nullable annotations to various methods and parameters. Changed return types of some methods to use thread-safe collections.
src/.../alert/Alert.java	Added @NotNull annotations to fields in Alert record.
src/.../alert/AlertManager.java	Added @NotNull annotations to method parameters, improving non-null safety.
src/.../btn/BtnNetwork.java	Added @NotNull annotations to constructor parameters.
src/.../btn/BtnRuleParsed.java	Added @NotNull annotations to method parameters and updated constructor logic.
src/.../config/MainConfigUpdateScript.java	Added @NotNull annotation to constructor parameter.
src/.../config/PBHConfigUpdater.java	Added @NotNull annotations to constructor parameters.
src/.../database/BanLog.java	Added @NotNull and @Nullable annotations to fields for better nullability specification.
src/.../database/DatabaseHelper.java	Added @NotNull and @Nullable annotations to method parameters.
src/.../database/DatabaseManager.java	Added @NotNull annotation to method parameter in setupDatabase.
src/.../database/RuleSubInfo.java	Added @NotNull annotations to fields in RuleSubInfo.
src/.../database/RuleSubLog.java	Added @NotNull annotations to fields in RuleSubLog.
src/.../downloader/Downloader.java	Added @NotNull and @Nullable annotations to method parameters and return types.
src/.../downloader/DownloaderBasicAuth.java	Added @NotNull annotations to fields in DownloaderBasicAuth record.
src/.../downloader/DownloaderInfo.java	Added @NotNull annotations to constructor parameters.
src/.../downloader/impl/biglybt/BiglyBT.java	Added @NotNull annotations to method parameters and return types.
src/.../downloader/impl/qbittorrent/QBittorrent.java	Added @NotNull annotations to method parameters and return types.
src/.../downloader/impl/qbittorrent/SingleTorrentPeer.java	Added @NotNull annotation to return type of getPeerAddress method.
src/.../downloader/impl/transmission/TRPeer.java	Added @NotNull annotation to return type of getPeerAddress method.
src/.../downloader/impl/transmission/TRTorrent.java	Added @NotNull annotations to return types of methods.

In files of code, clarity's realm did rise,
With @NotNull and @Nullable in their guise.
Robust and safe, our paths now trace,
A dance of data, a safer place.
From PeerBanHelper to Downloader's grind,
We’ve banished the nulls, now peace we find.
🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[Ghost-chu]

感觉有点奇怪，空安全注解那个 commit 我应该 force push 覆盖掉了

[PluieM]

感觉有点奇怪，空安全注解那个 commit 我应该 force push 覆盖掉了

不奇怪，我merge的时候应该还没有覆盖，那我先关了重新提