coderabbitai[bot]
commented
1 month ago Walkthrough
The recent changes implement a locking mechanism in the banWave method of PeerBanHelperServer to improve concurrency control. The Downloader interface now includes a default scheduling method, while the Transmission class has been updated to manage paused torrents using a DelayQueue. Additional localization updates provide warnings against using the deprecated Transmission adapter, enhancing overall system functionality.
Changes
| Files | Change Summary |
|---|---|
src/main/java/com/ghostchu/peerbanhelper/PeerBanHelperServer.java |
Added a ReentrantLock to the banWave method for concurrency control, including error handling for interruptions and ensuring thread-safe execution of ban wave logic. |
src/main/java/com/ghostchu/peerbanhelper/downloader/Downloader.java |
Introduced a default method runScheduleTasks() in the Downloader interface to enhance modularity. |
src/main/java/com/ghostchu/peerbanhelper/downloader/impl/transmission/Transmission.java |
Implemented a DelayQueue for managing paused torrents, replacing synchronous sleep with asynchronous handling. Updated relaunchTorrents to utilize this queue, and added a new static inner class DelayedTorrents. |
src/main/java/com/ghostchu/peerbanhelper/text/Lang.java |
Added a new enum constant DOWNLOADER_TRANSMISSION_DISCOURAGE for localization purposes. |
src/main/resources/lang/en_us/messages.yml |
Introduced a new warning message DOWNLOADER_TRANSMISSION_DISCOURAGE regarding the use of the Transmission adapter. |
src/main/resources/lang/messages_fallback.yml |
Added a new warning message about the deprecation of the Transmission adapter. |
src/main/resources/lang/zh_cn/messages.yml |
Added a new warning message about the deprecated status of the Transmission adapter in Chinese. |
webui/src/views/dashboard/components/editDownloaderModal.vue |
Disabled the "Transmission" radio button and wrapped it in a tooltip to discourage selection. |
webui/src/views/dashboard/locale/en-US.ts |
Added a new warning message for the dashboard about the use of the Transmission adapter. |
webui/src/views/dashboard/locale/zh-CN.ts |
Added a new warning message about the deprecated status of the Transmission adapter in Chinese. |
webui/src/views/oobe/components/addDownloader.vue |
Wrapped the "Transmission" radio button in a tooltip and disabled it to discourage its selection. |
Sequence Diagram(s)
sequenceDiagram
participant User
participant PeerBanHelperServer
participant Downloader
participant Transmission
User->>PeerBanHelperServer: Trigger banWave()
PeerBanHelperServer->>PeerBanHelperServer: Acquire banWaveLock
PeerBanHelperServer->>Downloader: runScheduleTasks()
Downloader->>Transmission: Update paused torrents
Transmission->>Transmission: Manage torrent states
PeerBanHelperServer->>PeerBanHelperServer: Release banWaveLock🐇 In the burrow, changes take flight,
With locks and queues, all feels just right.
Tasks run smoothly, torrents align,
In this new code, everything shines!
Hops of joy, let the magic unfold,
For each little change is a story told! 🐇
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
cloudflare-workers-and-pages[bot]
修复了 Transmission 暂停-重启的 BUG，并开始推进废弃 Transmission 适配器。
https://github.com/PBH-BTN/PeerBanHelper/issues/382
后端更改
-Dpbh.downloader.transmission.i-know-transmission-is-discourage-and-could-be-removed-in-future-please-dont-show-require-take-actions-status-text-and-i-know-what-i-am-doingJVM 附加参数前端更改
OOBE
Dashboard
Summary by CodeRabbit
New Features
banWavemethod to enhance concurrency control.runScheduleTasks()to theDownloaderinterface for improved modularity.Transmissionclass using a delay queue.User Interface Changes